Fix demo and upgrade to Pyodide v0.18.1 #181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous languagePluginLoader was deprecated and removed after v0.18.1
This reverts commit 51f64ed. Github doesn't have 3.10 enabled yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #180
After doing some investigation on this issue, I ran into this section of Pyodide documentation of its internal Javascript API. It turns out that the
languagePluginLoaderfunction is now deprecated. That's why the examples from the demo stopped working.This PR upgrades pyodide to v0.18.1 and change the JS code to integrate with p5.js to replace the deprecated function by
loadPyodide.