8000 Fix #3383 we should not exit when the process represented by pid is running by mengxunQAQ · Pull Request #3402 · benoitc/gunicorn · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix #3383 we should not exit when the process represented by pid is running #3402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix #3383 we should not exit when the process represented by pid is running #3402

wants to merge 1 commit into from

Conversation

mengxunQAQ
Copy link
  • Many software also have a pidfile, eg NGINX., but it does not exit just because the process number in the pidfile is running; it merely writes a new pid to the file
  • Whether to run repeatedly or not can be guaranteed by the user themselves

@mengxunQAQ
Fix benoitc#3383 we should not exit when the process represented by p…
66a710b 
…id is running

Signed-off-by: mengxun <mengxun1122@163.com>
@pajod
Copy link
Contributor
pajod commented Jun 17, 2025

The user can also guarantee to not place the PIDfile on persistent storage. This could be a documentation change only, while keeping the helpful (and, except in cases of rare pid recycling, generally the result of a clear mistake) error.

Side note: Anyone not interested in the old behavior is probably better served by running an init that remembers what processes it started (such as systemd) and never care about pid files ever again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mengxunQAQ @pajod
0