Notify workers of quick shutdown after graceful shutdown times out. #3388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per benoitc#3385 this allows to distinguish between graceful and abnormal termination and gives a chance to workers to do something about it (e.g. to log a stack trace). For backward compatibility, we keep the old 2 signals model if quick_shutdown_timeout is set to 0.
|
I like it, completely alleviates the concern that people might have depended on the previous behavior. Note to reviewers: This patch carefully retains two questionable behaviors, which should probably be changed separately:
However:
|
pajod
reviewed
Apr 16, 2025
| name = "quick_shutdown_timeout" | ||
| section = "Worker Processes" | ||
| cli = ["--quick-shutdown-timeout"] | ||
| meta = "INT" |
There was a problem hiding this comment.
Nitpick: point out the unit somewhere, possibly right here, where INT is misleading for a float option.
(meta[var] is just a text label anyway, so even SECONDS would be more clear about what is to be specified here)
There was a problem hiding this comment.
Let's resolve this for graceful_timeout first :) #3390
|
interesting try! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #3385 this allows to distinguish between graceful and abnormal termination and gives a chance to workers to do something about it (e.g. to log a stack trace).
For backward compatibility, we keep the old 2 signals model if quick_shutdown_timeout is set to 0.