8000 style: argparse inheritance, hide some options from --help by pajod · Pull Request #3272 · benoitc/gunicorn · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

style: argparse inheritance, hide some options from --help #3272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

style: argparse inheritance, hide some options from --help #3272

wants to merge 3 commits into from

Conversation

pajod
Copy link
Contributor
@pajod pajod commented Aug 13, 2024 •
edited
Loading

We have way too much options (#3266)

Idea: We could hide deprecated ones from --help, and possibly move both unstable and deprecated ones to their own, bottom-most section in the documentation.

Attached patch hacks (style improvements welcome) the config.py-class-to-argparse code so we can subclass while keeping metaclass intact. Then it adds a Deprecated class that hides certain settings from --help. I tried to avoid additional functional changes.

If this PR moves forward with minor changes, then the following changes are the next steps:

  1. change some options default value to None and have not specifying them mean "feature not used"
  2. permit and document some options with existing default to be overridden to some None-like value
  3. options that do not take effect based on environment / other options should be warned about
    • behavior of --bind fd://3 when LISTEN_FDS=1 set can be erratic & surprising
  4. boolean options should use argparse.BooleanOptionalAction (Python 3.9+)
    • paves the way to switch settings default-off to default-on without forcing admins to update their config

@pajod pajod mentioned this pull request Aug 14, 2024
Open
@pajod pajod mentioned this pull request Nov 24, 2024
Open
@pajod pajod mentioned this pull request Feb 4, 2025
Closed
@pajod pajod mentioned this pull request Mar 18, 2025
Open
@pajod pajod moved this to Awaiting: 1st review in @pajod Gunicorn issue sorting table Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Does the tmp_upload_dir setting actually do anything?
1 participant
@pajod
0