Nginx: running master process back at root #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing /dev/stdout hacks in order to make this work. Unnecessary precaution for unconnected master process, further mitigated with user namespaces going forward
3a8f65c to
34e6b31
Compare
|
👍 😞 |
|
@ko-be can't be too sad. its only the master nginx process, not the workers |
|
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can
2F4E
be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing /dev/stdout hacks in order to make this work. Unnecessary precaution for unconnected master process, further mitigated with user namespaces going forward.
Works around:
/dev/stdoutis inaccessible by an unprivileged user in a container started as root moby/moby#31243Allow running in Docker 1.12+ with user namespaces enabled and selinux in enforcing mode