FEATURE: Force regex-matched arguments to be named #1243
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
In my step matchers that are backed with
re
, I name all arguments explicitly, i.e.(?P<myarg>\w+)
.It is consistent with match naming with the other matchers (
{myarg}
), and I don’t have to worry about the order of the arguments in the callback for the matcher.And in the case when many optional arguments are to be matched, the current version of the regex matcher in Behave forces me to use the uncapture sequence a lot, for example:
Removing the
?:
sequences in the above would lead to an error similar to:With the present patch, only arguments named explicitly using the
?P<argument>
construct would be passed to the handler, simplifying the code and making it more readable:Tell me what you think, HTH!