8000 Using --graceful instead of -graceful since single hyphen is treaded as short version of a flag · Issue #5604 · beego/beego · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using --graceful instead of -graceful since single hyphen is treaded as short version of a flag #5604

Closed
bo-er opened this issue Feb 28, 2024 · 3 comments · Fixed by #5633
Closed

Using --graceful instead of -graceful since single hyphen is treaded as short version of a flag #5604

bo-er opened this issue Feb 28, 2024 · 3 comments · Fixed by #5633

Comments

@bo-er
Copy link
Contributor
bo-er commented Feb 28, 2024

  1. What version of Go and beego are you using (bee version)?
    the latest

  2. What operating system and processor architecture are you using (go env)?
    irrelevent to the problem

  3. What did you do?
    I have a project that is using both cobra and beego, when beego's graceful restart functionality is enabled, cobra treats "- graceful" as "-g" + "raceful"

  4. What did you expect to see?
    beego should restart the program using "--graceful" instead of "-graceful"

  5. What did you see instead?
    cobra now treats -graceful as "-g" + "raceful", and will return an error.

  6. Why
    The single hyphen is used with "short" argument like this:
    ./bin/abc -h
    While the double hyphen is used with "long" argument like this:
    ./bin/abc --help

IMHO, we should follow the common wisdom and make a small change:
image
@bo-er
Copy link
Contributor Author
bo-er commented Feb 29, 2024 •
edited
Loading

right now, I have to do a workaround like this:

for i, arg := range os.Args {
		if arg == "-graceful" {
			nos.Args[i] = "--graceful"
		}
	}

@flycash
Copy link
Collaborator
flycash commented Apr 6, 2024

good suggestion, can you help to raise a merge request?

@bo-er bo-er mentioned this issue Apr 7, 2024
Closed
bo-er added a commit to bo-er/beego that referenced this issue Apr 7, 2024
@bo-er
resolve beego#5604: using double instead of single hyphen when forkin…
d86cafb 
…g a child process.
@bo-er bo-er mentioned this issue Apr 7, 2024
Merged
@bo-er
Copy link
Contributor Author
bo-er commented Apr 7, 2024

good suggestion, can you help to raise a merge request?

Hi flycash, here is the merge request: #5633

flycash pushed a commit that referenced this issue Apr 12, 2024
@bo-er @flycash
resolve #5604: using double instead of single hyphen when forking a c…
d703f53 
…hild process.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

resolve #5604: using double instead of single hyphen argument bo-er/beego
Feature/issue 5604
2 participants
@flycash @bo-er
0