First fix for the XSSRays #1984
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….com/beefproject/beef into internal_error_when_creating_XSSrays lets update
|
hasnt been able to be reviewed, so i will merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4028
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Thanks for submitting a PR! Please fill in this template where appropriate:
Category
e.g. Bug
Feature/Issue Description
Q: Please give a brief summary of your feature/fix
A: related to #1983, when running XSSRays it fails in a catch for an internal server error. This is due to Ruby trickery that my simple fix resolves. There is likely to be more errors related to this that ill chase down later, however this one resolves this part of it and the specific ticket.
Q: Give a technical rundown of what you have changed (if applicable)
A: A fun fact about using the where function is that it returns ActiveRecord::Relation which basically acts like an array. Since its using that to find the record we have to go into it similar to how we would go into a hash that contains an array to grab the record. This is done by adding the .first
see the difference here:
with the top one, the reference gives the relational error but with the bottom one, it can actually access it.
Test Cases
Q: Describe your test cases, what you have covered and if there are any use cases that still need addressing.
A: Manually testing returns that its running but the results arent returning. Likely to be a similar issue in the code that i will raise a ticket for and run down.
Wiki Page
If you are adding a new feature that is not easily understood without context, please draft a section to be added to the Wiki below.
Nil