fix: avoid duplicate IP addresses #660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avoid scanning duplicated IPs for overlapping CIDRs. fixes bee-san#651
3f9362d to
b708c70
Compare
Great question!! I think it should be important, but if current tests fail against that then we should fix it later on. I think if I entered a list of IPs I would want them to be scanned in that order 🤔 |
bee-san
approved these changes
Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in the linked issue, if an IP appears twice (either duplicated directly or part of an overlapping CIDR), it's scanned multiple times and any open ports appear duplicated.
You can quickly see this via:
This proposed change loads everything into a
BTreeSetbefore converting it back into aVecwhich:maintains the original order (I think)doesn't maintain the original order, just the naturally-sorted order which match existing tests (is the original order important?)fixes #651