fix: KeyException when synced layer's base layer states are deleted #626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Fixes a KeyException when synced layer overrides reference deleted base states by filtering out null keys and adding a test to ensure cloning still succeeds.
- Added a unit test (
DeletedSyncedLayerOverridesAreExcluded) to verify no exception is thrown when a synced layer's base state is deleted. - Updated
VirtualLayerto exclude entries with missing (null) keys when building_syncedLayerMotionOverrides.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| UnitTests~/AnimationServices/VirtualLayerTest.cs | Added test to confirm cloning after base state deletion does not throw |
| Editor/API/AnimatorServices/VirtualObjects/VirtualLayer.cs | Filter out null keys in synced layer overrides dictionary creation |
Comments suppressed due to low confidence (1)
UnitTests~/AnimationServices/VirtualLayerTest.cs:171
- [nitpick] The test only checks that no exception is thrown but does not verify that overrides for the deleted state are actually excluded. Add an assertion (e.g., inspect the cloned controller’s overrides collection) to confirm the expected behavior.
context.Clone(committed);
| @@ -142,7 +142,8 @@ private VirtualLayer(CloneContext context, AnimatorControllerLayer layer, int ph | |||
| _stateMachine = context.Clone(layer.stateMachine); | |||
|
|
|||
| _syncedLayerMotionOverrides = SyncedLayerOverrideAccess.ExtractStateMotionPairs(layer) | |||
| ?.ToImmutableDictionary(kvp => context.Clone(kvp.Key), | |||
| ?.Where(kvp => kvp.Key).ToImmutableDictionary( | |||
There was a problem hiding this comment.
The predicate .Where(kvp => kvp.Key) is unclear and may not correctly filter out null states. Consider using kvp.Key != null (and potentially also kvp.Value != null) to explicitly exclude deleted base states.
Suggested change
| ?.Where(kvp => kvp.Key).ToImmutableDictionary( | |
| ?.Where(kvp => kvp.Key != null).ToImmutableDictionary( |
Copilot uses AI. Check for mistakes.
ce00f7b to
0a13b11
Compare
bdunderscore
added a commit
that referenced
this pull request
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: bdunderscore/modular-avatar#1577