fix: missing gesture layer mask can cause bicycle pose in play mode emulation #602
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR addresses an issue where a missing gesture layer mask could cause incorrect bicycle pose emulation in play mode. The changes add a new unit test to validate that FX and Gesture layers are properly assigned an avatar mask and update the VRChat platform animator bindings to set the mask accordingly.
- Added a new test in VRChatTests.cs to verify mask assignment.
- Updated VRChatPlatformAnimatorBindings.cs to assign the mask from the animator controller.
Reviewed Changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| UnitTests~/AnimationServices/VRChatTests.cs | Added a unit test ensuring that the animator mask is populated for FX and Gesture layers. |
| Editor/API/AnimatorServices/PlatformBindings/VRChatPlatformAnimatorBindings.cs | Updated layer binding logic to assign the avatar mask for FX and Gesture layers. |
Files not reviewed (2)
- UnitTests~/AnimationServices/_CommonAssets.meta: Language not supported
- UnitTests~/AnimationServices/_CommonAssets/ShapellAvatar.prefab.meta: Language not supported
Comments suppressed due to low confidence (1)
Editor/API/AnimatorServices/PlatformBindings/VRChatPlatformAnimatorBindings.cs:174
- [nitpick] Consider renaming 'innerLayers' to 'controllerLayers' to clarify its relation to the animator controller layers.
var innerLayers = ((AnimatorController)controller).layers;
|
|
||
| if (shouldHaveMask) | ||
| { | ||
| var controller = (AnimatorController)layer.animatorController; |
There was a problem hiding this comment.
The test assumes that the animator controller always includes at least one layer. Consider adding a check or assertion to verify that controller.layers is not empty before accessing its first element.
| var controller = (AnimatorController)layer.animatorController; | |
| var controller = (AnimatorController)layer.animatorController; | |
| Assert.IsTrue(controller.layers.Length > 0, "AnimatorController has no layers."); |
Copilot uses AI. Check for mistakes.
3fc2d68 to
23b37bc
Compare
23b37bc to
4301ef1
Compare
No description provided.