fix: loop time not preserved when there are animation events #600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 2 out of 19 changed files in this pull request and generated no comments.
Files not reviewed (17)
- UnitTests~/AnimationServices/LoopTimeIsPreserved.meta: Language not supported
- UnitTests~/AnimationServices/LoopTimeIsPreserved/LoopTime_OFF Event.anim: Language not supported
- UnitTests~/AnimationServices/LoopTimeIsPreserved/LoopTime_OFF Event.anim.meta: Language not supported
- UnitTests~/AnimationServices/LoopTimeIsPreserved/LoopTime_OFF RefClip Event.anim: Language not supported
- UnitTests~/AnimationServices/LoopTimeIsPreserved/LoopTime_OFF RefClip Event.anim.meta: Language not supported
- UnitTests~/AnimationServices/LoopTimeIsPreserved/LoopTime_OFF RefClip.anim: Language not supported
- UnitTests~/AnimationServices/LoopTimeIsPreserved/LoopTime_OFF RefClip.anim.meta: Language not supported
- UnitTests~/AnimationServices/LoopTimeIsPreserved/LoopTime_OFF.anim: Language not supported
- UnitTests~/AnimationServices/LoopTimeIsPreserved/LoopTime_OFF.anim.meta: Language not supported
- UnitTests~/AnimationServices/LoopTimeIsPreserved/LoopTime_ON Event.anim: Language not supported
- UnitTests~/AnimationServices/LoopTimeIsPreserved/LoopTime_ON Event.anim.meta: Language not supported
- UnitTests~/AnimationServices/LoopTimeIsPreserved/LoopTime_ON RefClip Event.anim: Language not supported
- UnitTests~/AnimationServices/LoopTimeIsPreserved/LoopTime_ON RefClip Event.anim.meta: Language not supported
- UnitTests~/AnimationServices/LoopTimeIsPreserved/LoopTime_ON RefClip.anim: Language not supported
- UnitTests~/AnimationServices/LoopTimeIsPreserved/LoopTime_ON RefClip.anim.meta: Language not supported
- UnitTests~/AnimationServices/LoopTimeIsPreserved/LoopTime_ON.anim: Language not supported
- UnitTests~/AnimationServices/LoopTimeIsPreserved/LoopTime_ON.anim.meta: Language not supported
Comments suppressed due to low confidence (1)
UnitTests~/AnimationServices/VirtualClipTest.cs:395
- [nitpick] The test 'LoopTime_IsPreserved_NoRefClip' is parameterized with a 'hasRefClip' flag, which may lead to ambiguity given that the PR title and description focus on scenarios without an additive reference clip. Consider splitting the test into distinct cases to clearly separate scenarios with and without a reference clip.
[Test]
When an animation clip contains animation events, but does not have an additive reference clip, we would fail to preserve animation settings such as loop time.
There was a problem hiding this comment.
Copilot reviewed 4 out of 21 changed files in this pull request and generated no comments.
Files not reviewed (17)
- UnitTests~/AnimationServices/LoopTimeIsPreserved.meta: Language not supported
- UnitTests~/AnimationServices/LoopTimeIsPreserved/LoopTime_OFF Event.anim: Language not supported
- UnitTests~/AnimationServices/LoopTimeIsPreserved/LoopTime_OFF Event.anim.meta: Language not supported
- UnitTests~/AnimationServices/LoopTimeIsPreserved/LoopTime_OFF RefClip Event.anim: Language not supported
- UnitTests~/AnimationServices/LoopTimeIsPreserved/LoopTime_OFF RefClip Event.anim.meta: Language not supported
- UnitTests~/AnimationServices/LoopTimeIsPreserved/LoopTime_OFF RefClip.anim: Language not supported
- UnitTests~/AnimationServices/LoopTimeIsPreserved/LoopTime_OFF RefClip.anim.meta: Language not supported
- UnitTests~/AnimationServices/LoopTimeIsPreserved/LoopTime_OFF.anim: Language not supported
- UnitTests~/AnimationServices/LoopTimeIsPreserved/LoopTime_OFF.anim.meta: Language not supported
- UnitTests~/AnimationServices/LoopTimeIsPreserved/LoopTime_ON Event.anim: Language not supported
- UnitTests~/AnimationServices/LoopTimeIsPreserved/LoopTime_ON Event.anim.meta: Language not supported
- UnitTests~/AnimationServices/LoopTimeIsPreserved/LoopTime_ON RefClip Event.anim: Language not supported
- UnitTests~/AnimationServices/LoopTimeIsPreserved/LoopTime_ON RefClip Event.anim.meta: Language not supported
- UnitTests~/AnimationServices/LoopTimeIsPreserved/LoopTime_ON RefClip.anim: Language not supported
- UnitTests~/AnimationServices/LoopTimeIsPreserved/LoopTime_ON RefClip.anim.meta: Language not supported
- UnitTests~/AnimationServices/LoopTimeIsPreserved/LoopTime_ON.anim: Language not supported
- UnitTests~/AnimationServices/LoopTimeIsPreserved/LoopTime_ON.anim.meta: Language not supported
Comments suppressed due to low confidence (1)
Editor/API/AnimatorServices/VirtualObjects/VirtualClip.cs:258
- Consider adding unit tests specifically targeting the new else branch to ensure that loop time and other clip settings are correctly preserved when no additive reference clip is provided.
AnimationUtility.SetAnimationClipSettings(_clip, settings);
bdunderscore
added a commit
that referenced
this pull request
Apr 17, 2025
When an animation clip contains animation events, but does not have an additive reference clip, we would fail to preserve animation settings such as loop time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an animation clip contains animation events, but does not have an additive reference clip, we would fail to preserve animation settings such as loop time.