8000 update device login message by rustyjux · Pull Request #125 · bcgov/gwa-cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

update device login message #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account 8000

Jump to bottom
Merged
merged 1 commit into from
Sep 10, 2024
Merged

update device login message #125

merged 1 commit into from
Sep 10, 2024

Conversation

rustyjux
Copy link
Contributor

Description

New output:

$ gwa login

To complete the login process, please follow these steps:
1. Open this URL in your web browser: http://keycloak.localtest.me:9081/auth/realms/master/device
2. Enter this code when prompted: JIQQ-KKFM
3. Complete the IDIR authentication process in your browser
4. Return to this terminal window after successful authentication

Waiting for you to complete the login process...

A lot more words but hopefully makes life more straightforward for the new/occasional user and existing users should have no trouble finding what they need.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (non-breaking change with enhancements to documentation)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

I'll also add a note in the techdocs when gwa login is introduced in tutorials to follow the prompts provided in the terminal.

timng-bcgov
timng-bcgov approved these changes Sep 10, 2024
View reviewed changes
Copy link
@timng-bcgov timng-bcgov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@rustyjux rustyjux merged commit af89578 into feature/ns-to-gw Sep 10, 2024
1 check passed
@rustyjux rustyjux deleted the feature/handshake-msg branch September 10, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timng-bcgov timng-bcgov timng-bcgov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rustyjux @timng-bcgov
0