Service validation #114
Merged
Service validation #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustyjux
approved these changes
Jul 8, 2024
There was a problem hiding this comment.
Looks good, works as expected in both interactive and when providing params along with generate-config.
One gripe is that when the suggestion is shown in the interactive (in the case of a service name conflict), the message disappears as soon as you start typing. More ideally, I feel like the message would persist while the user types or allow accepting the suggestion with a key press. But for now, I reckon this is a great improvement and in most cases just about any change the user makes will lead to avoiding a naming conflict.
Could also add testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Types of changes
Checklist
Further comments