8000 #4567 Ministry View Change Request Revamp (Ministry List UI) - Part -1 by bidyashish · Pull Request #4676 · bcgov/SIMS · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

#4567 Ministry View Change Request Revamp (Ministry List UI) - Part -1 #4676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 5, 2025
Merged

#4567 Ministry View Change Request Revamp (Ministry List UI) - Part -1 #4676

merged 1 commit into from
May 5, 2025

Conversation

bidyashish
Copy link
Collaborator

New Template API for application-change-request

@bidyashish bidyashish self-assigned this May 5, 2025
@bidyashish bidyashish added the Ministry Ministry Features label May 5, 2025
@sonarqubecloud SonarQubeCloud
Copy link
sonarqubecloud bot commented May 5, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link
github-actions bot commented May 5, 2025

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 21.9% ( 4027 / 18392 )
Methods: 9.91% ( 233 / 2352 )
Lines: 25.24% ( 3476 / 13773 )
Branches: 14.03% ( 318 / 2267 )

@github-actions GitHub Actions
Copy link
github-actions bot commented May 5, 2025

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 72.47% ( 679 / 937 )
Methods: 73.45% ( 83 / 113 )
Lines: 74.58% ( 531 / 712 )
Branches: 58.04% ( 65 / 112 )

@github-actions GitHub Actions
Copy link
github-actions bot commented May 5, 2025

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 85.75% ( 1511 / 1762 )
Methods: 83.41% ( 171 / 205 )
Lines: 88.12% ( 1246 / 1414 )
Branches: 65.73% ( 94 / 143 )

@github-actions GitHub Actions
Copy link
github-actions bot commented May 5, 2025

E2E SIMS API Coverage Report

Totals Coverage
Statements: 71.31% ( 6782 / 9510 )
Methods: 69.48% ( 840 / 1209 )
Lines: 74.78% ( 5261 / 7035 )
Branches: 53.79% ( 681 / 1266 )

@bidyashish bidyashish added the SIMS-Api SIMS-Api label May 5, 2025
andrewsignori-aot
andrewsignori-aot reviewed May 5, 2025
View reviewed changes
...pi/src/route-controllers/application-change-request/models/application-change-request.dto.ts
@@ -0,0 +1,12 @@
/**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can review the DTO once it is the final version.
As a minor comment, the "change request ID" is actually the application ID itself.
The studentId is probably not required and can be added later, if needed.
To allow the proper redirect, the parentApplicationId will be required.
This would be a recommended DTO, but we need also ensure the pagination.
If this is just used as a place holder, feel free to move ahead.

export class ApplicationChangeRequestPendingSummaryAPIOutDTO {
  applicationId: number;
  parentApplicationId: number;
  submittedDate: Date;
  firstName?: string;
  lastName: string;
  applicationNumber: string;
}

Copy link
Collaborator Author
8000

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review.
Will adjust in next PR.

andrewsignori-aot
andrewsignori-aot approved these changes May 5, 2025
View reviewed changes
Copy link
Collaborator
@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice start, only one comment but it can be adjusted in the upcoming PR.

sh16011993
sh16011993 approved these changes May 5, 2025
View reviewed changes
Copy link
Collaborator
@sh16011993 sh16011993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @bidyashish 👍 Thanks for creating the controller. 😄

@bidyashish bidyashish added this pull request to the merge queue May 5, 2025
Merged via the queue into main with commit 4785deb May 5, 2025
22 checks passed
@bidyashish bidyashish deleted the feature/4567-ministry-ui branch May 5, 2025 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sh16011993 sh16011993 sh16011993 approved these changes

@andrewsignori-aot andrewsignori-aot andrewsignori-aot approved these changes

Assignees

@bidyashish bidyashish

Labels
Ministry Ministry Features SIMS-Api SIMS-Api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bidyashish @sh16011993 @andrewsignori-aot
0