8000 #4657 - Remove permanent residency exception by ninosamson · Pull Request #4662 · bcgov/SIMS · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

#4657 - Remove permanent residency exception #4662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 1, 2025
Merged

#4657 - Remove permanent residency exception #4662

merged 2 commits into from
May 1, 2025

Conversation

ninosamson
Copy link
Collaborator
@ninosamson ninosamson commented May 1, 2025 •
edited
Loading

Documentation Collection Maintained

  • The application still prompts students who indicate they are Permanent Residents to upload supporting documentation (e.g., PR card, landing documents).
  • The document upload field is visible and required for this user type when the Permanent resident option is selected
  • Upload is still a mandatory field
  • All program years, except FT 25/26, which will be covered in Bypass partner declaration exception (DV)  #4517

Exception Path no longer required

  • Selection of “Permanent Resident” no longer routes the application into the exception approval path in the workflow.
  • Permanent Resident status is treated as a standard question

@ninosamson ninosamson added Student Student Features Form.io Form IO definitions changed. labels May 1, 2025
@ninosamson ninosamson self-assigned this May 1, 2025
@ninosamson ninosamson added the Waiting Waiting for other activity, requirement or deliverable before it can be actioned. label May 1, 2025
@sonarqubecloud SonarQubeCloud
Copy link
sonarqubecloud bot commented May 1, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link
github-actions bot commented May 1, 2025

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 21.83% ( 4014 / 18385 )
Methods: 9.91% ( 233 / 2352 )
Lines: 25.2% ( 3469 / 13768 )
Branches: 13.77% ( 312 / 2265 )

@ninosamson ninosamson marked this pull request as draft May 1, 2025 23:15
@github-actions GitHub Actions
Copy link
github-actions bot commented May 1, 2025

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 72.47% ( 679 / 937 )
Methods: 73.45% ( 83 / 113 )
Lines: 74.58% ( 531 / 712 )
Branches: 58.04% ( 65 / 112 )

@ninosamson ninosamson removed the Waiting Waiting for other activity, requirement or deliverable before it can be actioned. label May 1, 2025
@github-actions GitHub Actions
Copy link
github-actions bot commented May 1, 2025

E2E SIMS API Coverage Report

Totals Coverage
Statements: 71.28% ( 6772 / 9500 )
Methods: 69.45% ( 839 / 1208 )
Lines: 74.75% ( 5252 / 7026 )
Branches: 53.79% ( 681 / 1266 )

@github-actions GitHub Actions
Copy link
github-actions bot commented May 1, 2025

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 85.75% ( 1511 / 1762 )
Methods: 83.41% ( 171 / 205 )
Lines: 88.12% ( 1246 / 1414 )
Branches: 65.73% ( 94 / 143 )

@ninosamson ninosamson requested a review from bidyashish May 1, 2025 23:25
@ninosamson ninosamson marked this pull request as ready for review May 1, 2025 23:26
sh16011993
sh16011993 approved these changes May 1, 2025
View reviewed changes
Copy link
Collaborator
@sh16011993 sh16011993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @ninosamson 👍

@andrewsignori-aot andrewsignori-aot mentioned this pull request May 1, 2025
Merged
bidyashish
bidyashish approved these changes May 1, 2025
View reviewed changes
Copy link
Collaborator
@bidyashish bidyashish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @ninosamson

github-merge-queue bot pushed a commit that referenced this pull request May 1, 2025
@andrewsignori-aot
#4517 - Bypass partner declaration exception (DV) (#4651)
45f2e2d 
- Create a new DB enum entry for the `marriedUnable` option.
- Adjusted backend conversions for federal integrations to follow the
same codes used for `Married`,
- Adjusted the "independent" logic in the Student Application to ensure
it will be considered independant.
- Created a new set of styles to allow a panel (container) customization
as a banner that accepts child components (see image below).
- Change the uploader information to use a single component and a single
new CSS class `file-upload-info-container`.

## Full-time Student application


![image](https://github.com/user-attachments/assets/9f1cc5a6-aaa5-4b94-92f0-cb54d11480be)

### Some styles were adjusted to ensure the validation message followed
the others.


![image](https://github.com/user-attachments/assets/a6c3f7df-296f-4d00-a38d-92b7eae1a315)

## Ministry New Exception


![image](https://github.com/user-attachments/assets/4ea7ffc9-38f7-4bb0-ba10-517db4c45599)

## TODO
- Add some E2E tests for integrations using the new `marriedUnable`
option.
- Execute the same changes on part-time.

## Migration Revert


![image](https://github.com/user-attachments/assets/32430b95-cfe1-4cda-a7e1-e3bcb9ff0ebe)

## Removed Citizenship for permanent residency

"Citizenship for permanent residency" was removed as part of #4662
dheepak-aot
dheepak-aot approved these changes May 1, 2025
View reviewed changes
Copy link
Collaborator
@dheepak-aot dheepak-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

andrewsignori-aot
andrewsignori-aot approved these changes May 1, 2025
View reviewed changes
Copy link
Collaborator
@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ninosamson ninosamson added this pull request to the merge queue May 1, 2025
Merged via the queue into main with commit d00aeec May 1, 2025
22 checks passed
@ninosamson ninosamson deleted the feature/#4657-removePR-dependency branch May 1, 2025 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sh16011993 sh16011993 sh16011993 approved these changes

@bidyashish bidyashish bidyashish approved these changes

@dheepak-aot dheepak-aot dheepak-aot approved these changes

@andrewsignori-aot andrewsignori-aot andrewsignori-aot approved these changes

Assignees

@ninosamson ninosamson

Labels
Form.io Form IO definitions changed. Student Student Features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ninosamson @sh16011993 @bidyashish @dheepak-aot @andrewsignori-aot
0