8000 Show installed drivers versions by carlosms · Pull Request #202 · bblfsh/web · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Show installed drivers versions #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 12, 2019
Merged

Show installed drivers versions #202

merged 2 commits into from
Mar 12, 2019

Conversation

carlosms
Copy link
Collaborator
@carlosms carlosms commented Mar 8, 2019

Fix #158.

a

smacker
smacker reviewed Mar 8, 2019
View reviewed changes
@smacker
Copy link
Collaborator
smacker commented Mar 8, 2019

CI is failing

se7entyse7en
se7entyse7en reviewed Mar 8, 2019
View reviewed changes
src/components/Footer.js Outdated
const languageVersions = Object.keys(languages).reduce((acc, k) => {
const { version, name } = languages[k];

if (version === undefined) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When this happens?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the (auto) language is found. I changed this to make it more clear in 8d31e67.

@carlosms carlosms force-pushed the driver-versions branch 2 times, most recently from 684deeb to 8d31e67 Compare 8000 March 8, 2019 16:01
carlosms added 2 commits March 8, 2019 16:18
@carlosms
Add driver version to POST /drivers response
08ea5d7 
Signed-off-by: Carlos Martín <carlos.martin.sanchez@gmail.com>
@carlosms
Show drivers versions in UI
5b53108 
Signed-off-by: Carlos Martín <carlos.martin.sanchez@gmail.com>
@carlosms carlosms merged commit d0df114 into bblfsh:master Mar 12, 2019
@carlosms carlosms deleted the driver-versions branch March 12, 2019 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smacker smacker smacker approved these changes

@se7entyse7en se7entyse7en se7entyse7en approved these changes

@dpordomingo dpordomingo Awaiting requested review from dpordomingo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carlosms @smacker @se7entyse7en
0