reduce re-renders, holding down backspace now works properly #4
Conversation
- Holding down backspace will move the cursor as the content is deleted
- Holding down any other key does not do anything, prior leading to unexpected presses
- Instead of rerendering each char on every key press only toggle classes to highlight correct/incorrect
- Holding down backspace will move the cursor as the content is deleted - Holding down any other key does not do anything, prior leading to unexpected presses - Instead of rerendering each char on every key press only toggle classes to highlight correct/incorrect
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thanks for the PR. A few regressions
Also while you are fixing those, make sure you set the random words generation to 1000 and enable |
Oh, I completely forgot to take a look at Backspace works completely fine for me on local & https://typer-git-fork-adxy-optimise-reaper.vercel.app/, can you explain the issue? Also, I am not sure about the use case of |
As in , if I was to select all and do a backspace, that no longer works due to the It's not a usecase but default behaviour of the editor, on 2nd thought, we could ignore it and just add |
Also, I've tested the |
|
LGTM! |