8000 chore: fund mainnet ledgers by xenoliss · Pull Request #333 · base/contract-deployments · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: fund mainnet ledgers #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8000
Merged
merged 4 commits into from
May 9, 2025
Merged

chore: fund mainnet ledgers #333

merged 4 commits into from
May 9, 2025

Conversation

xenoliss
Copy link
Contributor
@xenoliss xenoliss commented May 6, 2025

This PR adds a task to fund mainnet ledgers (see corresponding task).

@cb-heimdall
Copy link
Collaborator
cb-heimdall commented May 6, 2025

✅ Heimdall Review Status

Requirement Status More Info
Reviews 2/1
Denominator calculation 8000
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@xenoliss xenoliss requested review from jackchuma and henridevieux May 6, 2025 17:12
@xenoliss xenoliss requested a review from mdehoog May 8, 2025 07:07
mdehoog
mdehoog previously approved these changes May 8, 2025
Copy link
Contributor
@jackchuma jackchuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a handful of comments to address. Also, noticing now that our multisig on Base mainnet is a 7-of-7 and two of the addresses are not accounted for in our internal docs. We probably need to address this in a separate task. Could consider funding our base ledgers from the mainnet multisig through the L1 -> L2 bridge instead

Make sure your ledger is still unlocked and run the following.

```bash
make sign
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need to update this to specify make sign-ethereum and make sign-base as those are the commands specified in your makefile. Also ensure the readme makes it clear that there are two signatures needed

@wbnns wbnns added the base protocol review To be reviewed by the Base web team label May 8, 2025
@cb-heimdall cb-heimdall dismissed stale reviews from mdehoog and jackchuma May 8, 2025 15:55

Approved review 2824154205 from mdehoog is now dismissed due to new commit. Re-request for approval.

@xenoliss xenoliss requested review from jackchuma and mdehoog May 8, 2025 19:33
Comment on lines +146 to +149
Coinbase facilitator:

```bash
SIGNATURES=AAAABBBB make execute
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still should probably specify execute-ethereum or execute-base in this code block, no?

@xenoliss xenoliss merged commit d3bfe80 into main May 9, 2025
5 checks passed
@xenoliss xenoliss deleted the bo/fund-ledgers-base-mainnet branch May 9, 2025 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
base protocol review To be reviewed by the Base web team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0