-
Notifications
You must be signed in to change notification settings - Fork 154
chore: fund mainnet ledgers #333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Heimdall Review Status
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a handful of comments to address. Also, noticing now that our multisig on Base mainnet is a 7-of-7 and two of the addresses are not accounted for in our internal docs. We probably need to address this in a separate task. Could consider funding our base ledgers from the mainnet multisig through the L1 -> L2 bridge instead
Make sure your ledger is still unlocked and run the following. | ||
|
||
```bash | ||
make sign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will need to update this to specify make sign-ethereum
and make sign-base
as those are the commands specified in your makefile. Also ensure the readme makes it clear that there are two signatures needed
Approved review 2824154205 from mdehoog is now dismissed due to new commit. Re-request for approval.
Coinbase facilitator: | ||
|
||
```bash | ||
SIGNATURES=AAAABBBB make execute |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still should probably specify execute-ethereum
or execute-base
in this code block, no?
This PR adds a task to fund mainnet ledgers (see corresponding task).