feat: add template for funding from safe #329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Heimdall Review Status
|
jackchuma
reviewed
May 1, 2025
jackchuma
reviewed
May 2, 2025
jackchuma
reviewed
May 6, 2025
Makefile
Outdated
| git remote add origin https://github.com/ethereum-optimism/optimism.git; \ | ||
| git fetch --depth=1 origin $(OP_COMMIT); \ | ||
| git reset --hard FETCH_HEAD | ||
| @if grep -q "^OP_COMMIT=" .env 2>/dev/null; then \ |
There was a problem hiding this comment.
A task won't build for me without an OP_COMMIT. I think it's because the base contracts use OP utility files under the hood
This reverts commit 599706e.
jackchuma
approved these changes
May 6, 2025
henridevieux
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a template to easily create tasks for funding new facilitator ledgers.