8000 [feat] cmd for query prices on each sources by tanut32039 · Pull Request #112 · bandprotocol/bothan · GitHub

More Web Proxy on the site http://driver.im/

[feat] cmd for query prices on each sources #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

tanut32039 wants to merge 17 commits into add-telemetry from cmd-call-sources

Contributor

tanut32039 commented

•

Implementation details

Add new command for Bothan to be able to query prices for each source ex. bothan query binance btcusdt

Please ensure the following requirements are met before submitting a pull request:

The pull request is targeted against the correct target branch
The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
The pull request includes a description of the implementation/work done in detail.
The pull reque 8000 st includes any appropriate unit/integration tests
You have added a relevant changelog entry to CHANGELOG.md
You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the GitHub PR explorer)

Tanut Lertwarachai added 2 commits

April 4, 2025 16:55


          fix logic

bc4dc6f


          clippy fix

0dc8000

tanut32039 requested review from RogerKSI and warittornc

April 4, 2025 10:01

tanut32039 changed the base branch from main to add-telemetry

April 4, 2025 10:01


          arrange toml

16b7b9e

tanut32039 removed request for RogerKSI and warittornc

April 4, 2025 10:05


          refac

da84d7b

tanut32039 requested review from warittornc and RogerKSI

April 4, 2025 10:11


          nigtly fix

c8e620a

RogerKSI requested review from taobun, nkitlabs, colmazia and Copilot

April 7, 2025 16:08

Copilot AI reviewed

View reviewed changes

Copilot AI left a comment

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

bothan-lib/src/worker/rest.rs Outdated Show resolved Hide resolved

warittornc requested changes

View reviewed changes

bothan-api/server-cli/src/commands/query.rs Outdated Show resolved Hide resolved

bothan-api/server-cli/src/commands/query.rs Outdated Show resolved Hide resolved

bothan-api/server-cli/src/commands/query.rs Outdated Show resolved Hide resolved

bothan-api/server-cli/src/commands/query.rs Outdated Show resolved Hide resolved

bothan-lib/src/worker/rest.rs Outdated Show resolved Hide resolved

bothan-api/server-cli/src/commands/query.rs Outdated Show resolved Hide resolved

bothan-api/server-cli/src/commands/query.rs Outdated Show resolved Hide resolved

bothan-api/server-cli/src/commands/query.rs Outdated Show resolved Hide resolved

bothan-api/server-cli/src/commands/query.rs Outdated Show resolved Hide resolved

bothan-api/server-cli/src/commands/query.rs Outdated Show resolved Hide resolved


          fix comment

2d135a4

tanut32039 requested a review from warittornc

April 9, 2025 04:06


          add distinct ids func

d322bad

nkitlabs reviewed

View reviewed changes

Collaborator

nkitlabs left a comment •

-

bothan-api/server-cli/src/commands/query.rs Outdated Show resolved Hide resolved

bothan-api/server-cli/src/commands/query.rs Outdated Show resolved Hide resolved

bothan-api/server-cli/src/commands/query.rs Outdated Show resolved Hide resolved

bothan-api/server-cli/src/commands/query.rs Outdated Show resolved Hide resolved

warittornc requested a review from Copilot

April 10, 2025 07:35

Copilot AI reviewed

View reviewed changes

Copilot AI left a comment

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

warittornc requested changes

View reviewed changes

bothan-api/server-cli/src/commands/query.rs Outdated Show resolved Hide resolved

bothan-api/server-cli/src/commands/query.rs Outdated Show resolved Hide resolved

bothan-api/server-cli/src/commands/query.rs Outdated Show resolved Hide resolved

bothan-api/server-cli/src/commands/query.rs Outdated Show resolved Hide resolved

bothan-api/server-cli/src/commands/query.rs Outdated Show resolved Hide resolved

bothan-api/server-cli/src/commands/query.rs Outdated Show resolved Hide resolved

bothan-api/server-cli/src/commands/query.rs Outdated Show resolved Hide resolved

bothan-api/server-cli/src/commands/query.rs Outdated Show resolved Hide resolved

bothan-api/server-cli/src/commands/query.rs Outdated Show resolved Hide resolved

bothan-api/server-cli/src/commands/query.rs Outdated Show resolved Hide resolved

Tanut Lertwarachai added 2 commits

April 11, 2025 14:34


          fix comment

c53ad3a


          del clone

4f3ded0

tanut32039 requested review from nkitlabs and warittornc

April 11, 2025 07:43


          shorten task

ae95b8e

warittornc requested changes

View reviewed changes

bothan-api/server-cli/src/commands/query.rs Outdated Show resolved Hide resolved

bothan-api/server-cli/src/commands/query.rs Outdated Show resolved Hide resolved

bothan-api/server-cli/src/commands/query.rs Outdated Show resolved Hide resolved

bothan-api/server-cli/src/commands/query.rs Outdated Show resolved Hide resolved

bothan-api/server-cli/src/commands/query.rs Outdated Show resolved Hide resolved

bothan-api/server-cli/src/commands/query.rs Outdated Show resolved Hide resolved

bothan-api/server-cli/src/commands/query.rs Outdated Show resolved Hide resolved

bothan-api/server-cli/src/commands/query.rs Show resolved Hide resolved

bothan-api/server-cli/src/commands/query.rs Outdated Show resolved Hide resolved

bothan-api/server-cli/src/commands/query.rs Outdated Show resolved Hide resolved

Tanut Lertwarachai added 3 commits

April 16, 2025 15:12


          refac

221aec5


          refac

665b4bd


          use ok_or

f47892f

tanut32039 requested a review from warittornc

April 16, 2025 08:21

warittornc reviewed

View reviewed changes

bothan-api/server-cli/src/commands/query.rs Outdated Show resolved Hide resolved

bothan-api/server-cli/src/commands/query.rs Outdated Show resolved Hide resolved

bothan-api/server-cli/src/commands/query.rs Outdated Show resolved Hide resolved

bothan-api/server-cli/src/commands/query.rs Outdated Show resolved Hide resolved

bothan-api/server-cli/src/commands/query.rs Outdated Show resolved Hide resolved

bothan-api/server-cli/src/commands/query.rs Outdated Show resolved Hide resolved

Tanut Lertwarachai added 3 commits

April 16, 2025 16:29


          fix comment

1f00d5a


          rename func

2a87b31


          refac

44e5b1b

Contributor

colmazia commented

Don't copy P'Folk, add description to the PR please.

Member

warittornc commented

Don't copy P'Folk, add description to the PR please.

this is just the default description, adding details under implementation details should suffice

colmazia requested a review from warittornc

April 18, 2025 07:42

colmazia approved these changes

View reviewed changes


          rearrange import

0d1851b

RogerKSI reviewed

View reviewed changes

bothan-api/server-cli/src/commands/query.rs Show resolved Hide resolved

bothan-api/server-cli/src/commands/query.rs Show resolved Hide resolved

RogerKSI self-requested a review

May 8, 2025 12:01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

colmazia colmazia approved these changes

taobun Awaiting requested review from taobun

nkitlabs Awaiting requested review from nkitlabs

warittornc Awaiting requested review from warittornc

RogerKSI Awaiting requested review from RogerKSI

Labels

None yet

0