8000 issue=1299, update code to 2.7.0 by PengyuSun · Pull Request #1300 · baidu/tera · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

issue=1299, update code to 2.7.0 #1300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 9, 2017
Merged

issue=1299, update code to 2.7.0 #1300

merged 1 commit into from
Aug 9, 2017

Conversation

PengyuSun
Copy link
Collaborator
@PengyuSun PengyuSun commented Jul 26, 2017 •
edited by bluebore
Loading

caijieming-ng
caijieming-ng reviewed Jul 26, 2017
View reviewed changes
src/zk/zk_util.cc Outdated
@@ -9,7 +9,7 @@

#include <gflags/gflags.h>
#include <glog/logging.h>
#include <zookeeper/zookeeper.h>
#include <zookeeper.h>

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

你确定能编译通过？

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

编译设置、编译依赖重新进行了调整

bluebore
bluebore reviewed Jul 27, 2017
View reviewed changes
src/leveldb/db/db_impl.cc Outdated
@@ -1894,29 +1894,29 @@ uint64_t DBImpl::GetLastSequence(bool is_locked) {
retval = versions_->LastSequence();
}
if (is_locked) {
mutex_.Unlock();
mutex_.Unlock();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

类似这种改动有不少，目的是什么？

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

缩进问题吧

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

看起来是改反了。。

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

缩进引发的代码变更已经全部恢复了

@caijieming-ng
Copy link
Collaborator

LGTM

@caijieming-ng
Copy link
Collaborator

将commit log合并成一个

caijieming-ng
caijieming-ng approved these changes Aug 4, 2017
View reviewed changes
Copy link
Collaborator
@caijieming-ng caijieming-ng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

合并commit log

@lylei
Copy link
Collaborator
lylei commented Aug 7, 2017

这个代码是干啥的？修了什么bug，做了什么升级？

@yvxiang
Copy link
Collaborator
yvxiang commented Aug 7, 2017

能把主要的功能点写下吗？

@PengyuSun
Copy link
Collaborator Author

1.单行事务的读支持读取多版本
2.修复 ts zk_adapter 因版本diff暴露出的watch逻辑bug
3.sdk支持多tera集群读写
4.GC重构部分代码fix
5.trackableGC无法删除目录bug fix
6.编译依赖、配置项更新

@bluebore
Copy link
Collaborator
bluebore commented Aug 9, 2017

看起来没啥大问题@皮皮虾 再看下吧

@yvxiang
Copy link
Collaborator
yvxiang commented Aug 9, 2017

LGTM

@yvxiang yvxiang merged commit 0ea6884 into baidu:master Aug 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yvxiang yvxiang yvxiang left review comments

@bluebore bluebore bluebore approved these changes

@caijieming-ng caijieming-ng caijieming-ng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@PengyuSun @caijieming-ng @lylei @yvxiang @bluebore
0