issue=#1202 ts unload all tablets on exit #1203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taocp
reviewed
Mar 1, 2017
| Counter worker_count; | ||
| worker_count.Set(tablet_ios.size()); | ||
|
|
||
| for (uint32_t i = 0; i < tablet_ios.size(); ++i) { |
There was a problem hiding this comment.
这里单机的unload没有并发控制，是计划在分布式操作系统这个层次控制每秒kill的tabletserver数量？
There was a problem hiding this comment.
掉tabletnode_imple的unload接口，比调用tabletio的unload接口，更合理否（内部会从tablet_manager中删除tablet）
There was a problem hiding this comment.
从tablet-manager中删掉会造成not in range错误，meta表压力变高；
直接调用UnloadTablet接口需要再find一次tablet-io
|
LGTM |
| delete tablet_meta; | ||
| std::vector<common::Thread> unload_threads; | ||
| unload_threads.resize(tablet_ios.size()); | ||
|
|
There was a problem hiding this comment.
不会，跟tablet-writer线程的数量一样
| } | ||
| tablet_io->DecRef(); | ||
| worker_count->Dec(); | ||
| } |
There was a problem hiding this comment.
tablet_io在另外一个线程解引用，感觉不好理解
caijieming-ng
approved these changes
Mar 3, 2017
00k
added a commit
that referenced
this pull request
Apr 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kill -9: <1s (keep all log)
load: 75s (recover all log)
...........................................................................................................................
kill: 15s (dump memtable and clean all log)
load: <1s (only read CURRENT and menifest)