Make MachineEnv a per-ABI property #6957
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@uweigand happy to merge once the merge conflict is resolved... |
The MachineEnv structure contains the allocatable and preferred register sets. This is 8000 currently fixed per TargetIsa - however, conceptually these register sets can differ between ABIs on the same ISA. To allow for this, replace the TargetIsa machine_env routine with an ABIMachineSpec get_machine_env routine. To ensure the structure is still only allocated once, cache it via static OnceLock variables. No functional change intended.
47c4534 to
032aed8
Compare
I've rebased now. |
eduardomourar
pushed a commit
to eduardomourar/wasmtime
that referenced
this pull request
Sep 13, 2023
The MachineEnv structure contains the allocatable and preferred register sets. This is currently fixed per TargetIsa - however, conceptually these register sets can differ between ABIs on the same ISA. To allow for this, replace the TargetIsa machine_env routine with an ABIMachineSpec get_machine_env routine. To ensure the structure is still only allocated once, cache it via static OnceLock variables. No functional change intended.
<
6DD9
!-- -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MachineEnv structure contains the allocatable and preferred register sets. This is currently fixed per TargetIsa - however, conceptually these register sets can differ between ABIs on the same ISA.
To allow for this, replace the TargetIsa machine_env routine with an ABIMachineSpec get_machine_env routine. To ensure the structure is still only allocated once, cache it via static OnceLock variables.
No functional change intended.
FYI @cfallin - this is what I suggested in last week's meeting.