8000 Fix: message size check in timeout test by monrax · Pull Request #1014 · buger/goreplay · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix: message size check in timeout test #1014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 5, 2021
Merged

Fix: message size check in timeout test #1014

merged 1 commit into from
Oct 5, 2021

Conversation

monrax
Copy link
Contributor
@monrax monrax commented Oct 1, 2021

Fix message size check in TestMessageTimeoutReached. Since the message parser has parsed two packets of size 63 << 10, then the message size should be 63 << 11

@CLAassistant
Copy link
CLAassistant commented Oct 1, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@sonarqubecloud
Copy link
sonarqubecloud bot commented Oct 1, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

urbanishimwe
urbanishimwe approved these changes Oct 5, 2021
View reviewed changes
Copy link
Collaborator
@urbanishimwe urbanishimwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @monrax

@buger buger merged commit df73b91 into buger:master Oct 5, 2021
buger pushed a commit that referenced this pull request Oct 6, 2021
@monrax @buger
Fix: message size check in timeout test (#1014)
f8ef77e 
Fix message size check in `TestMessageTimeoutReached`. Since the message parser has parsed two packets of size 63 << 10, then the message size should be 63 << 11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urbanishimwe urbanishimwe urbanishimwe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@monrax @CLAassistant @urbanishimwe @buger
0