8000 rpcserver: add GetBlockStats by guilhermep · Pull Request #1656 · btcsuite/btcd · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

rpcserver: add GetBlockStats #1656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

rpcserver: add GetBlockStats #1656

wants to merge 1 commit into from

Conversation

guilhermep
Copy link

Adds GetBlockStats implementation to rpcserver.

This is my first PR. Any feedback is appreciated.

Fixes #1630 (partially).

@jcvernaleo
Copy link
Member

Thanks for the PR!

Could you fix it so the tests pass before we review? Thanks!

@coveralls
Copy link
coveralls commented Nov 3, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 399629124

  • 0 of 345 (0.0%) changed or added relevant lines in 1 file are covered.
  • 8 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.5%) to 52.934%
Changes Missing Coverage Covered Lines Changed/Added Lines %
rpcserver.go 0 345 0.0%
Files with Coverage Reduction New Missed Lines %
peer/peer.go 2 75.47%
btcec/signature.go 3 92.48%
connmgr/connmanager.go 3 86.07%
Totals Coverage Status
Change from base Build 381748156: -0.5%
Covered Lines: 20828
Relevant Lines: 39347
💛 - Coveralls

@onyb onyb added the rpc label Nov 10, 2020
@jcvernaleo
Copy link
Member

Thanks for the lint fixing. Looks like it has conflicts though. Could you rebase and fix those please?

@jakesylvestre jakesylvestre added this to the 0.22.0 milestone Dec 4, 2020
@jcvernaleo jcvernaleo modified the milestones: 0.22.0, 0.22.1 May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement rpc
Projects
None yet
Milestone
0.22.1
Development

Successfully merging this pull request may close these issues.

Blockstats and blockchaininfo command missing
5 participants
@guilhermep @jcvernaleo @coveralls @onyb @jakesylvestre
0