8000 Fix Relative Imports (e.g. `--ruleset=override.translation_ruleset`) by fritz-astronomer · Pull Request #53 · astronomer/orbiter · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Relative Imports (e.g. --ruleset=override.translation_ruleset) #53

Merged
merged 4 commits into from
Feb 28, 2025
Merged

Fix Relative Imports (e.g. --ruleset=override.translation_ruleset) #53

merged 4 commits into from
Feb 28, 2025

Conversation

fritz-astronomer
Copy link
Contributor
  • fix: allow relative import by adding to syspath if ModuleNotFoundError

@codecov-commenter
Copy link
codecov-commenter commented Feb 28, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 74.52%. Comparing base (b3ee237) to head (a3ef5ba).
Report is 27 commits behind head on main.

Files with missing lines Patch % Lines
orbiter/__main__.py 33.33% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
- Coverage   78.92%   74.52%   -4.41%     
==========================================
  Files          35       39       +4     
  Lines        1362     1688     +326     
==========================================
+ Hits         1075     1258     +183     
- Misses        287      430     +143

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fritz-astronomer fritz-astronomer merged commit 5e8bdfc into main Feb 28, 2025
6 checks passed
@fritz-astronomer fritz-astronomer deleted the imports branch February 28, 2025 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fritz-astronomer @codecov-commenter
0