8000 fix: make bang variant of field aggregates work correctly by rbino · Pull Request #954 · ash-project/ash · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: make bang variant of field aggregates work correctly #954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 27, 2024
Merged

fix: make bang variant of field aggregates work correctly #954

merged 1 commit into from
Mar 27, 2024

Conversation

rbino
Copy link
Contributor
@rbino rbino commented Mar 27, 2024

split_aggregate_opts/1 was called too early so it didn't handle the translation of :read_action to :action, leading to a NimbleOptions error during validation

Contributor checklist

  • Bug fixes include regression tests
  • Chores
  • Documentation changes
  • Features include unit/acceptance tests
  • Refactoring
  • Update dependencies

@rbino
fix: make bang variant of field aggregates work correctly
2b96187 
split_aggregate_opts/1 was called too early so it didn't handle the translation
of :read_action to :action, leading to a NimbleOptions error during validation
@zachdaniel zachdaniel merged commit b7cfddf into ash-project:main Mar 27, 2024
@zachdaniel
Copy link
Contributor

🚀 Thank you for your contribution! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachdaniel zachdaniel zachdaniel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rbino @zachdaniel
0