8000 fix: fix types for `min`/`max` constraints in `Type.Float` by vonagam · Pull Request #718 · ash-project/ash · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: fix types for min/max constraints in Type.Float #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2023
Merged

fix: fix types for min/max constraints in Type.Float #718

merged 1 commit into from
Oct 2, 2023

Conversation

vonagam
Copy link
Contributor
@vonagam vonagam commented Oct 2, 2023

Seems like Type.Float was copied from Type.Decimal but the types were left as is from decimal. Unless I am missing something it should not work as there is no decimal method in Type.Float.

@zachdaniel zachdaniel merged commit 6d94582 into ash-project:main Oct 2, 2023
@zachdaniel
Copy link
Contributor

🚀 Thank you for your contribution! 🚀

@vonagam vonagam deleted the fix-float-min-max-constraints branch October 2, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachdaniel zachdaniel zachdaniel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vonagam @zachdaniel
0