Pagination: support pagination's count on actions besides reads
#1229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rbino would you have a few to look into this? |
17df397 to
b3a3d3d
Compare
rbino
reviewed
Jun 8, 2024
b3a3d3d to
f517af9
Compare
zachdaniel
reviewed
Jun 10, 2024
Ensure that relationships can be correctly loaded, even with pagination, on the resources resulting from create, update and delete actions. Signed-off-by: Davide Briani <davide.briani@secomind.com>
f517af9 to
04057ad
Compare
|
🚀 Thank you for your contribution! 🚀 |
rbino
reviewed
Jun 10, 2024
| @@ -178,6 +178,8 @@ defmodule Ash.Actions.Read do | |||
|
|
|||
| query = load_and_select_sort(query) | |||
|
|
|||
| query = add_relationship_count_aggregates(query) | |||
There was a problem hiding this comment.
If this is now done here shouldn't it be removed from line 435?
There was a problem hiding this comment.
I'll do that and push it up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read actions support specifying pagination options on
loadstatements for relationships.These options are correctly respected, and the
count: trueoption results in Ash counting the total number of related resources and returning the count in the page returned as the loaded relationship.However, actions such as
Ash.update!/3do not properly respect theloadoption since the resultingcountfield is left asnil.The PR adds a sample failing test.
Contributor checklist