8000 fix: add resource to Ash.Seed.seed! in Ash.Generator.seed! by TimisRobert · Pull Request #1227 · ash-project/ash · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: add resource to Ash.Seed.seed! in Ash.Generator.seed! #1227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 7, 2024
Merged

fix: add resource to Ash.Seed.seed! in Ash.Generator.seed! #1227

merged 1 commit into from
Jun 7, 2024

Conversation

TimisRobert
Copy link
Contributor

Contributor checklist

  • Bug fixes include regression tests
  • Chores
  • Documentation changes
  • Features include unit/acceptance tests
  • Refactoring
  • Update dependencies

@zachdaniel zachdaniel merged commit 4d35117 into ash-project:main Jun 7, 2024
@TimisRobert
Copy link
Contributor Author
TimisRobert commented Jun 7, 2024 •
edited
Loading

There is another small issue, seed_input will generate :__keep_nil for some values, and Ash.Seed.seed!:113 does not account for that, so it will throw an Invalid Error since it's not a valid value.

@zachdaniel
Copy link
Contributor

Do you want to make a separate PR with a fix for that? Or open an issue?

@TimisRobert
Copy link
Contributor Author

I will open a new PR, I'm fixing it right now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachdaniel zachdaniel zachdaniel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TimisRobert @zachdaniel
0