8000 fix: use correct boolean operation names in Filter.find/4 by rbino · Pull Request #1214 · ash-project/ash · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: use correct boolean operation names in Filter.find/4 #1214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2024
Merged

fix: use correct boolean operation names in Filter.find/4 #1214

merged 1 commit into from
May 30, 2024

Conversation

rbino
Copy link
Contributor
@rbino rbino commented May 30, 2024

Contributor checklist

  • Bug fixes include regression tests
  • Chores
  • Documentation changes
  • Features include unit/acceptance tests
  • Refactoring
  • Update dependencies

@rbino
Copy link
Contributor Author
rbino commented May 30, 2024

I've found this by chance while reading the implementation to see what Filter.find/4 was doing, I don't have enough context on Filter to create a regression test but I guess one wouldn't hurt (from what I see this could affect optimized boolean expression generation)

@rbino rbino changed the title fix: use correct binary operation names in Filter.find/4 fix: use correct boolean operation names in Filter.find/4 May 30, 2024
@rbino rbino force-pushed the fix-op-find-filter branch from 9c5867f to 1abc15d Compare May 30, 2024 12:39
@zachdaniel zachdaniel merged commit d71718c into ash-project:main May 30, 2024
30 checks passed
@zachdaniel
Copy link
Contributor

🚀 Thank you for your contribution! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachdaniel zachdaniel zachdaniel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rbino @zachdaniel
0