8000 feat: make atomics work even if expr err is not supported by barnabasJ · Pull Request #1718 · ash-project/ash · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: make atomics work even if expr err is not supported #1718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 16, 2025
Merged

feat: make atomics work even if expr err is not supported #1718

merged 4 commits into from
Jan 16, 2025

Conversation

barnabasJ
Copy link
Contributor

Contributor checklist

  • Bug fixes include regression tests
  • Chores
  • Documentation changes
  • Features include unit/acceptance tests
  • Refactoring
  • Update dependencies

@barnabasJ barnabasJ marked this pull request as draft January 15, 2025 23:40
@barnabasJ barnabasJ force-pushed the feat/make-atomics-work-even-if-expr-err-is-not-supported branch from cbd61ba to e62799a Compare January 15, 2025 23:44
@zachdaniel
Copy link
Contributor

weird test failures 😓

@barnabasJ barnabasJ marked this pull request as ready for review January 16, 2025 14:51
@barnabasJ barnabasJ self-assigned this Jan 16, 2025
@barnabasJ barnabasJ added bug Something isn't working enhancement New feature or request labels Jan 16, 2025
@barnabasJ barnabasJ requested a review from zachdaniel January 16, 2025 14:51
@zachdaniel
Copy link
Contributor

LGTM 👍

@barnabasJ barnabasJ merged commit fcba9fd into main Jan 16, 2025
36 checks passed
@barnabasJ barnabasJ deleted the feat/make-atomics-work-even-if-expr-err-is-not-supported branch January 16, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachdaniel zachdaniel zachdaniel approved these changes

Assignees

@barnabasJ barnabasJ

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@barnabasJ @zachdaniel
0