10000 Appropriate defaults for IdleMaxAge and IdleConnectionTestPeriod in Bone... by Blobson · Pull Request #53 · aselab/scala-activerecord · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Appropriate defaults for IdleMaxAge and IdleConnectionTestPeriod in Bone... #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 9, 2014
Merged

Appropriate defaults for IdleMaxAge and IdleConnectionTestPeriod in Bone... #53

merged 1 commit into from
Sep 9, 2014

Conversation

Blobson
Copy link
Contributor
@Blobson Blobson commented Sep 8, 2014

Following fix eliminates issue #49 by setting non-zero values for IdleMaxAge and IdleConnectionTestPeriod.
This will force BoneCP to wait IdleMaxAge seconds before marking connection as idle and connection is likely to be reused. If IdleMaxAge is set to zero, BoneCP marks connection as Idle instantly after query execution and will not reuse this connection or close it until maxConnectionAge is expired in which case it is pretty easy to exhaust connection pool of any size.

@y-yoshinoya y-yoshinoya merged commit c6f2d5d into aselab:master Sep 9, 2014
y-yoshinoya added a commit that referenced this pull request Sep 9, 2014
@y-yoshinoya
#53 Changed the default value to the optional value
3df8364
y-yoshinoya added a commit that referenced this pull request Sep 9, 2014
@y-yoshinoya
Merge branch 'Blobson-boncp-maxIdleAge'
3197596 
* Blobson-boncp-maxIdleAge:
  #53 Changed the default value to the optional value
  Appropriate defaults for IdleMaxAge and IdleConnectionTestPeriod in BoneCP configuration - fixed issue #49
@y-yoshinoya
Copy link
Member

Thank you for your pull request.
I was cannot decide that whether or not to default behavior to check whether idle in every 30 milliseconds...
Sorry, I was changed the code partially.

Thank you.

@Blobson
Copy link
Contributor Author
Blobson commented Sep 9, 2014

Actually it was 30 seconds (not milliseconds), but in any case it is better to let the user decide which values to use. Thanks for your work on the project, can't wait for the next release ;)

@Blobson Blobson deleted the boncp-maxIdleAge branch September 9, 2014 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Blobson @y-yoshinoya
0