8000 CI: Test in 2x2 multi-node configuration by adding optional MAX_NODE_SIZE override by lukeshingles · Pull Request #78 · artis-mcrt/artis · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

CI: Test in 2x2 multi-node configuration by adding optional MAX_NODE_SIZE override #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 57 commits into from
Jun 3, 2024
Merged

CI: Test in 2x2 multi-node configuration by adding optional MAX_NODE_SIZE override #78

merged 57 commits into from
Jun 3, 2024

Conversation

lukeshingles
Copy link
Member
@lukeshingles lukeshingles commented Jun 1, 2024 •
edited
Loading

Replace nebularonezone test with nebular three-zone test so ensure that both nodes (and both ranks on node 0) are assigned cells in update grid.

lukeshingles and others added 8 commits May 29, 2024 09:43
@lukeshingles
Update rpkt.cc
8dc57d9
@jpollin98 @lukeshingles
Normalise bound-free estimators on each rank independently to elimina…
8c7b996 
…te MPI_Bcast and skip NLTE solver if Te=MINTEMP (#54)

**Normalise bound-free estimators independently on all ranks**
The normalisation of the bf estimators has been changed to occur across
all cells instead of the rank-assigned cells. This means that we no
longer need to broadcast the prev_bfratenormed array.

**Skip NLTE solver if Te=MINTEMP:**
The temperature check was added due to populations in some grid cells
with a low temperature, as populations being unphysical (i.e producing
nne outsude of the limits of a float). These grid cells typically had a
lower amount of 56Ni.
@lukeshingles
Update .renovate.json
096857d
@lukeshingles
exspec-after.sh: only plot vspecpol if vpkt.txt exists
d5d4a7d
@lukeshingles
Remove redundant if condition
ad27a49
@lukeshingles
Enable estimators conversion to parquet
f983c1b
@lukeshingles
Remove redundant struct member ffheating and keep phixslist pointer i…
ba942df 
…n Rpkt_continuum_absorptioncoeffs (#75)
@lukeshingles
Add cpplint config and style fixes (#77)
d3fc3f3
@lukeshingles lukeshingles changed the title CI: test in 2x2 multi-node MPI configuration CI: Add MAX_NODE_SIZE override and test in 2x2 multi-node configuration Jun 1, 2024
10000
lukeshingles added 21 commits June 2, 2024 23:35
@lukeshingles lukeshingles force-pushed the develop branch 4 times, most recently from 5f3e020 to 5be7dfb Compare June 3, 2024 12:38
@lukeshingles lukeshingles changed the title CI: Add MAX_NODE_SIZE override and test in 2x2 multi-node configuration CI: Test in 2x2 multi-node configuration by adding optional MAX_NODE_SIZE override Jun 3, 2024
@lukeshingles lukeshingles marked this pull request as ready for review June 3, 2024 12:42
@lukeshingles lukeshingles merged commit 6f710eb into develop Jun 3, 2024
46 of 48 checks passed
@lukeshingles lukeshingles deleted the ci_multinode branch June 3, 2024 13:41
@lukeshingles lukeshingles mentioned this pull request Jun 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukeshingles @jpollin98
0