8000 v2023.10 by lukeshingles · Pull Request #40 · artis-mcrt/artis · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

v2023.10 #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 975 commits into from
Oct 21, 2023
Merged

v2023.10 #40

merged 975 commits into from
Oct 21, 2023

Conversation

lukeshingles
Copy link
Member
@lukeshingles lukeshingles commented Sep 25, 2023 •
edited
Loading

New features

  • New 2D Cylindrical propagation grid option (for direct mapping of 2D input models)
  • Added test models for various combinations of 1D/2D input models and 1D/2D/3D propagation grids.
  • EXPERIMENTAL: Allow hybrid NLTE mode with some elements in full Non-LTE and other elements in either LTE or photoionisation equilibrium (classic quasi NLTE). Set with artisoptions.h LEVEL_IS_NLTE()
  • EXPERIMENTAL: Enforce Saha ionisation balance (allowing NLTE level pops) with artisoptions.h FORCE_SAHA_ION_BALANCE() function.
  • EXPERIMENTAL: FORCE_SPHERICAL_ESCAPE_SURFACE to remove the corners of a 2D or 3D model to create a spherical escape surface (allowing for increased velocity per axis cutoff). Cells with v_r_mid > vmax are set to empty, and packets found in cells with vel_r_inner > vmax are set to escaped.

Fixes

  • Fix virtual packets (storage of bound-free departure coeff in cell history had introduced a dependence on the not-updated cell history)
  • Fix for bug in 1D spherical grid mode that caused a some packets to get out of their correct cells. Now ready for production use. Mapping of 1D and 2D models to a 3D Cartesian grid is still possible, but no longer recommended for new models.
  • Fix adiabatic cooling rate with NLTE populations on, replacing nnetot (free and bound electron density) with nntot (ion plus free electron density). No change to W7 nebular spectrum.

@lukeshingles
Use more get_ionestimindex
68cfc14
@lukeshingles
Revert "Update radfield.cc"
05eb6eb 
This reverts commit 4621386.
@lukeshingles
Use std::vector<int> for mg_associated_cells, nonemptymgi_of_mgi, mgi…
778470a 
…_of_nonemptymgi
@lukeshingles
Use std::vector for traceemissionabsorption
e263095
@lukeshingles
Fixup
536785c
@lukeshingles
Update radfield.cc
e92a440
@lukeshingles
Refactor calculate_ion_balance_nne()
a3fd2b9
@lukeshingles
Remove optional NLTE_POPS_ALL_IONS_SIMULTANEOUS and always use multi-…
45ded3f 
…ion solver when NLTE_POPS_ON
@lukeshingles
Update ltepop.cc
873c15e
@lukeshingles
Detect NLTE levels
0726a84
@lukeshingles
Revert "Detect NLTE levels"
5697a89 
This reverts commit 0726a84.
@lukeshingles
add globals::elements.has_nlte_levels
ca30d4e
@lukeshingles
Update input.cc
cfe533c
@lukeshingles
Refactor
7b3fa64
@lukeshingles
Update atomic.cc
1d978d9
@lukeshingles
Rename has_nlte_levels to elem_has_nlte_levels
edb432d
@lukeshingles
Revert breaking changes
98ee0ca
@lukeshingles
Update input.cc
8017818
@lukeshingles
Update atomic.cc
b6d6dd0
@lukeshingles
Update ltepop.cc
11a56ae
@lukeshingles
Update update_grid.cc
e7f6737
@lukeshingles
Update update_grid.cc
a3242d1
@lukeshingles
Update update_grid.cc
06f4788
@lukeshingles
Revert "Update update_grid.cc"
60e8f74 
This reverts commit 06f4788.
@lukeshingles
Update update_grid.cc
5d372c7
@lukeshingles
Update update_grid.cc
aaa3511
@lukeshingles
Update sn3d.cc
daf6fc3
@lukeshingles
Save nne and nnetot
c2fe84f
@lukeshingles
Update grid.cc
7e59bfa
@lukeshingles
Fixup read gridsave
161b535
@lukeshingles lukeshingles changed the title v2023.x v2023.10 Oct 20, 2023
@lukeshingles lukeshingles merged commit 00661cf into main Oct 21, 2023
@lukeshingles lukeshingles deleted the develop branch October 21, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lukeshingles
0