Use system/vcpkg spdlog when available otherwise fallback to fetchcontent #3139
Conversation
17f69f6 to
548c4da
Compare
9bbd315 to
dd52b19
Compare
|
Turns out the issue is with the dependency of spdlog, fmt whose latest version on vcpkg has compilation issues. I am working on a workaround. Will update the PR once it is ready |
|
the work around seemed to work on local windows setup, I wonder why it failed on CI after the change - I will look into the windows problem. |
I think this is due to a100 system being blocked by me for running another benchmark. I will shut that down now that I don't need it further. Will post windows update soon. Update: Was able to reproduce this on Windows local build. Looking into it. Update2: Bummer, I missed the spdlog include directory for nvcc compiled object files (different from afcuda target). |
eb1cb50 to
ad55a26
Compare
Although the build isn't broken, since forge project setup runs before arrayfire fetch content variables are set, fetch-content-variables that doesn't have suffixes are set by forge project specific settings. This change fixes that.
Description
This change enables using system/vcpkg spdlog when available otherwise fallback to fetchcontent workflow. I have also udpated the spdlog version to 1.8.5 from the archaic 1.0.0 version. Fortunately, there were no issues like we encountered with fix releases during the version update of spdlog.
Apart from this, I have corrected the extern arrayfire deps download location; This is just a folder organization change, didn't fix any build issue.
Changes to Users
None
Checklist
[ ] Functions added to unified API[ ] Functions documented