8000 Fixes for __WIN32 build: by mmaroti · Pull Request #135 · arminbiere/cadical · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fixes for __WIN32 build: #135

New issue 8000

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixes for __WIN32 build: #135

wants to merge 1 commit into from

Conversation

mmaroti
Copy link
@mmaroti mmaroti commented Apr 24, 2025
  • __WIN32 is replaced with _WIN32 (both were used inconsistently)
  • CADICAL_ATTRIBUTE_FORMAT is disabled
  • __builtin_clz is replaced with _BitScanReverse
  • getpid is replaced with GetCurrentProcessId
  • PRETTY_FUNCTION is replaced with FUNCTION
    • 83CD
  • __builtin_prefetch is replaced with _m_prefetch
  • unistd.h is always guarded with #ifdef
  • io operations (isatty, etc) are defined with macros

@mmaroti
Fixes for __WIN32 build:
0903b45 
* __WIN32 is replaced with _WIN32 (both were used inconsistently)
* CADICAL_ATTRIBUTE_FORMAT is disabled
* __builtin_clz is replaced with _BitScanReverse
* getpid is replaced with GetCurrentProcessId
* __PRETTY_FUNCTION__ is replaced with __FUNCTION__
* __builtin_prefetch is replaced with _m_prefetch
* unistd.h is always guarded with #ifdef
* io operations (isatty, etc) are defined with macros
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mmaroti
0