8000 orangepi5pro: Fix uboot compilation by EvilOlaf · Pull Request #8181 · armbian/build · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

orangepi5pro: Fix uboot compilation #8181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 12, 2025
Merged

orangepi5pro: Fix uboot compilation #8181

merged 3 commits into from
May 12, 2025
+63 −1

Conversation

EvilOlaf
Copy link
Member
@EvilOlaf EvilOlaf commented May 12, 2025 •
edited
Loading

Description

Addresses #8172 or tries to at least.

This needs testing before merge.

How Has This Been Tested?

  • build
  • boot: nope, no hw

Checklist:

Please delete options that are not relevant.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented May 12, 2025 •
edited
Loading

Walkthrough

The change updates the assignment of the BOOTPATCHDIR variable within the post_family_config__orangepi5pro_use_vendor_uboot function in the Orange Pi 5 Pro board configuration script. The value of BOOTPATCHDIR is changed from "legacy/u-boot-orangepi5-rk3588" to simply "legacy". No other variables, logic, or exported entities are modified.

Possibly related PRs

  • nanopi-r3s: bump uboot to v2025.04 #8070: Updates BOOTPATCHDIR and BOOTBRANCH variables in a similar configuration function for the NanoPi R3S board, affecting related variables in a different board context.

Suggested reviewers

  • igorpecovnik
  • efectn

Tip

⚡️ Faster reviews with caching
  • CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.

Enjoy the performance boost—your workflow just got faster.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added 05 Milestone: Second quarter release size/medium PR with more then 50 and less then 250 lines Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... labels May 12, 2025
coderabbitai[bot]
coderabbitai bot reviewed May 12, 2025
View reviewed changes
Copy link
Contributor
@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
config/boards/orangepi5pro.csc (1)

56-56: Verify patch directory correctness and unify quoting style

The change simplifies BOOTPATCHDIR from "legacy/u-boot-orangepi5-rk3588" to "legacy". Please ensure that:

  1. The legacy directory actually exists in the U-Boot patch repository (e.g., under your patches/ hierarchy) and contains all required patches—otherwise the build may silently succeed but miss critical fixes.
  2. For consistency with the surrounding assignments (BOOTSOURCE and BOOTBRANCH use single quotes), consider switching to single quotes:
- BOOTPATCHDIR="legacy"
+ BOOTPATCHDIR='legacy'
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6e3ad9b and 998c2bb.

⛔ Files ignored due to path filters (1)
  • patch/u-boot/legacy/board_orangepi5pro/fix-noble-build.patch is excluded by !patch/**
📒 Files selected for processing (1)
  • config/boards/orangepi5pro.csc (1 hunks)

@igorpecovnik igorpecovnik added the Ready to merge Reviewed, tested and ready for merge label May 12, 2025
@igorpecovnik igorpecovnik merged commit d965e2a into armbian:main May 12, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@igorpecovnik igorpecovnik igorpecovnik approved these changes

@chainsx chainsx Awaiting requested review from chainsx chainsx is a code owner

@joekhoobyar joekhoobyar Awaiting requested review from joekhoobyar joekhoobyar is a code owner

@lanefu lanefu Awaiting requested review from lanefu lanefu is a code owner

Assignees
No one assigned
Labels
05 Milestone: Second quarter release Hardware Hardware related like kernel, U-Boot, ... Needs review Seeking for review Patches Patches related to kernel, U-Boot, ... Ready to merge Reviewed, tested and ready for merge size/medium PR with more then 50 and less then 250 lines
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EvilOlaf @igorpecovnik
0