8000 Update prepare-host.sh to use ntpsec-ntpdate by squassina · Pull Request #8177 · armbian/build · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update prepare-host.sh to use ntpsec-ntpdate #8177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 12, 2025
Merged

Update prepare-host.sh to use ntpsec-ntpdate #8177

merged 1 commit into from
May 12, 2025

Conversation

squassina
Copy link
Contributor
@squassina squassina commented May 10, 2025 •
edited
Loading

Description

migrate to ntpsec-ntpdate as a more secure implementation of ntpdate and available in Debian and Ubunbtu

GitHub issue reference: #8176
Jira Ticket: https://armbian.atlassian.net/browse/AR-2679

How Has This Been Tested?

build the images in Armbian Debian and Ubuntu that didn't have ntpdate installed and the ntpsec-ntpdate package was correctly installed and used.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

@squassina
Update prepare-host.sh
4eebaf6 
migrate to ntpsec-ntpdate as a more secure implementation of ntpdate and available in Debian and Ubunbtu
@squassina squassina requested a review from a team as a code owner May 10, 2025 21:32
@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented May 10, 2025 •
edited
Loading

Walkthrough

The change updates the adaptative_prepare_host_dependencies function in the prepare-host.sh script by replacing the pa 8000 ckage ntpdate with ntpsec-ntpdate in the global list of host dependencies. No other logic, control flow, or error handling in the script is modified.

Possibly related issues

Suggested labels

ready to merge

Tip

⚡️ Faster reviews with caching
  • CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.

Enjoy the performance boost—your workflow just got faster.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e8894a7 and 4eebaf6.

📒 Files selected for processing (1)
  • lib/functions/host/prepare-host.sh (1 hunks)
🔇 Additional comments (1)
lib/functions/host/prepare-host.sh (1)

196-198: Replace ntpdate with ntpsec-ntpdate in host dependencies

Migrating to the more secure ntpsec-ntpdate package is a solid improvement. However, the clock‐sync step (around line 105) still invokes ntpdate. Please verify that installing ntpsec-ntpdate still provides a working ntpdate binary (e.g., via a symlink), or update the invocation to explicitly call ntpsec-ntpdate to prevent potential failures when the original ntpdate is absent.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added 05 Milestone: Second quarter release size/small PR with less then 50 lines Needs review Seeking for review Framework Framework components labels May 10, 2025
@squassina squassina changed the title Update prepare-host.sh Update prepare-host.sh to use ntpsec-ntpdate May 10, 2025
@coderabbitai coderabbitai bot added the Ready to merge Reviewed, tested and ready for merge label May 10, 2025
@squassina
Copy link
Contributor Author

Adding that this package is available in various versions of Ubuntu (https://packages.ubuntu.com/search?keywords=ntpsec-ntpdate&searchon=names&suite=all&section=all) and Debian (https://packages.debian.org/search?suite=default&section=all&arch=any&searchon=names&keywords=ntpsec-ntpdate)

@igorpecovnik igorpecovnik merged commit c897044 into armbian:main May 12, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorpecovnik igorpecovnik igorpecovnik approved these changes

Assignees
No one assigned
Labels
05 Milestone: Second quarter release Framework Framework components Needs review Seeking for review Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@squassina @igorpecovnik
0