Update the version of U-boot used with Radxa rock 4 se to v2025.04 #8115
Conversation
|
""" WalkthroughThe changes update the board configuration file for the "Rock 4SE" board. The Possibly related PRs
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
config/boards/rock-4se.csc(1 hunks)
🔇 Additional comments (1)
config/boards/rock-4se.csc (1)
5-5:✅ Verification successful
Confirm U-Boot version bump and tag syntax.
The
BOOTBRANCH_BOARDvalue was updated to"tag:v2025.04"to pick up the new U‑Boot release. Please verify that this tag name exactly matches an existing tag in the U‑Boot repository; otherwise the build will fall back to the wrong branch.
🏁 Script executed:
#!/bin/bash # Verify that the tag exists upstream if git ls-remote https://github.com/u-boot/u-boot.git | grep -q "refs/tags/v2025.04\$"; then echo "✔ Tag v2025.04 found in u-boot repo" else echo "❌ Tag v2025.04 not found; please check the tag name" exit 1 fiLength of output: 165
✔ U-Boot tag v2025.04 exists and syntax is correct
- Verified in config/boards/rock-4se.csc (line 5):
BOOTBRANCH_BOARD="tag:v2025.04"- The
v2025.04tag is present in the upstream U‑Boot repository, so no further changes are needed.
|
emmc boot works too? |
|
I dont have the hardware to test emmc.
So far flashed and booted from an sd-card.
Known issue on rock 4 se with emmc boot?
…-------- Original Message --------
On 4/22/25 17:51, Werner wrote:
emmc boot works too?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
EvilOlaf left a comment (armbian/build#8115)
emmc boot works too?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
No known issues but wouldn't be the first time to introduce regressions on version bump ;) |
Update the version of U-boot used with rock 4 se. Tested locally on my board after building an armbian image. ubuntu@rock-4se:~$ strings /dev/mmcblk1 | grep U-Boot U-Boot SPL 2025.04-armbian-2025.04-S3482-P4a0b-H3d34-Va9af-Bb703-R448a (Apr 22 2025 - 10:05:17 +0000) U-Boot phase U-Boot FIT image for U-Boot with bl31 (TF-A)
|
@trappiz as I mentioned in a prior comment the existing |
Revert BOOTCONFIG and update BOOT_FDT_FILE="rk3399-rock-4se.dtd"
Set BOOTCONFIG="rock-4se-rk3399_defconfig"
Been updated now :) |
|
This ready to merge now? |
Should be ready to merge. However Im not able to test it until next week... :/ |
No problem. If you want to be more serious about this board, check this. |
|
https://paste.armbian.com/beducabasa It doesn't build, hmm. Probably patch folder should be set to BOOTPATCHDIR='v2025.04' |
|
But earlier it said it didnt find any patches.
I think this can be related to the change of BOOTCONFIG.
…-------- Original Message --------
On 4/26/25 08:06, Igor wrote:
igorpecovnik left a comment [(armbian/build#8115)](#8115 (comment))
https://paste.armbian.com/beducabasa It doesn't build, hmm. Probably patch folder should be set to BOOTPATCHDIR='v2025.04'
—
Reply to this email directly, [view it on GitHub](#8115 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AAZNSYEHRUCX3525XOYIGJL23MO7HAVCNFSM6AAAAAB3TZI22SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMZRHA4DSNBTGU).
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
No, that is unrelated. BOOTPATCHDIR tells where to look for patches and they are not compatible with the choosen uboot version. This is expected. Both things has to be aligned and if this device does not need any patches, it has to be set to empty folder. But try as proposed first from previous post. |
Created #8129 now. Lets hope it resolves it |
Yes, now its all green. https://github.com/armbian/os/actions/runs/14696507346/job/41239116465 |
…rmbian#8115) * Update rock-4se.csc Update the version of U-boot used with rock 4 se. Tested locally on my board after building an armbian image. ubuntu@rock-4se:~$ strings /dev/mmcblk1 | grep U-Boot U-Boot SPL 2025.04-armbian-2025.04-S3482-P4a0b-H3d34-Va9af-Bb703-R448a (Apr 22 2025 - 10:05:17 +0000) U-Boot phase U-Boot FIT image for U-Boot with bl31 (TF-A) * Use BOOTCONFIG="rock-4se-rk3399_defconfig" and remove BOOTPATCHDIR * Removed old comment * Update rock-4se.csc Revert BOOTCONFIG and update BOOT_FDT_FILE="rk3399-rock-4se.dtd" * Update rock-4se.csc Set BOOTCONFIG="rock-4se-rk3399_defconfig"
Update the version of U-boot used with Radxa rock 4 se to v2025.04.
Tested locally on my board after building an armbian image.
ubuntu@rock-4se:~$ strings /dev/mmcblk1 | grep U-Boot U-Boot SPL 2025.04-armbian-2025.04-S3482-P4a0b-H3d34-Va9af-Bb703-R448a (Apr 22 2025 - 10:05:17 +0000) U-Boot phase
U-Boot
FIT image for U-Boot with bl31 (TF-A)
Description
Update the version of U-boot used with Radxa rock 4 se.
GitHub issue reference:
Jira reference number [AR-9999]
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.
Checklist:
Please delete options that are not relevant.