8000 Disable broken AIC8800 wifi driver on Rockchip vendor kernel by igorpecovnik · Pull Request #8101 · armbian/build · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Disable broken AIC8800 wifi driver on Rockchip vendor kernel #8101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 19, 2025
Merged

Disable broken AIC8800 wifi driver on Rockchip vendor kernel #8101

merged 1 commit into from
Apr 19, 2025

Conversation

igorpecovnik
Copy link
Member
@igorpecovnik igorpecovnik commented Apr 18, 2025 •
edited
Loading

Description

Recent Rockchip vendor bump caused this driver to break. I have looked a bit, but I don't have this WiFi except on Allwinner, disabling it to make CI working, is what I can do.

@schwar3kat @HeyMeco
If any of you have time for this. Revert it back, once it gets fixed.

How Has This Been Tested?

  • Building image which has this extension enabled.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented Apr 18, 2025 •
edited
Loading

Walkthrough

A conditional check has been added at the beginning of the post_install_kernel_debs__install_aic8800_dkms_package function within the extensions/radxa-aic8800.sh script. This check determines if the current kernel branch is "vendor". If so, it issues a warning alert that compilation on the vendor kernel is broken and exits the function early, thereby skipping the installation of the aic8800 DKMS package. This new logic is placed before the existing version check that bypasses installation for kernels version 6.15 or newer. No changes were made to the function's signature or to any other exported or public entities; the modification is limited to the internal logic of the function.

Possibly related PRs

Suggested labels

ready to merge

Suggested reviewers

  • schwar3kat
📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cdf8eb8 and 91432d1.

📒 Files selected for processing (1)
  • extensions/radxa-aic8800.sh (1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
extensions/radxa-aic8800.sh (1)
.github/generate_CODEOWNERS.sh (1)
  • display_alert (6-6)
🔇 Additional comments (1)
extensions/radxa-aic8800.sh (1)

13-16: Quote variables in branch check and add a revert TODO

The current check [[ ${BRANCH} == vendor ]] risks mishandling if $BRANCH is empty or contains whitespace. It’s also helpful to leave a clear TODO/FIXME referencing the upstream issue so this workaround isn’t forgotten. For example:

-	if [[ ${BRANCH} == vendor ]]; then
+	# TODO: disable AIC8800 DKMS on Rockchip vendor kernel until driver is fixed upstream (see issue/PR link)
+	if [[ "${BRANCH}" == "vendor" ]]; then

[ suggest_optional_refactor ] [ suggest_nitpick ]

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added 05 Milestone: Second quarter release size/small PR with less then 50 lines Needs review Seeking for review Framework Framework components labels Apr 18, 2025
@coderabbitai coderabbitai bot added the Ready to merge Reviewed, tested and ready for merge label Apr 18, 2025
@HeyMeco
Copy link
Contributor
HeyMeco commented Apr 18, 2025

Tagging @amazingfate because he had fixed AIC8800 breaking on vendor kernel prior too.

I don't have anything with this hardware to look into it.

@schwar3kat
Copy link
Contributor

I will have a look. It may need to wait a few days,

@amazingfate
Copy link
Contributor

I will check it

@igorpecovnik
Copy link
Member Author

Tnx, i will merge this so we have a working CI.

@igorpecovnik igorpecovnik merged commit e2b5c43 into main Apr 19, 2025
1 check passed
@igorpecovnik igorpecovnik deleted the aicbroke branch April 19, 2025 05:52
@amazingfate
Copy link
Contributor

Fix pr is created upstream: radxa-pkg/aic8800#33

@HeyMeco
Copy link
Contributor
HeyMeco commented Apr 19, 2025

Fix pr is created upstream: radxa-pkg/aic8800#33

Do you know if the fix breaks pre 6.1.115 Rockchip BSP?

@amazingfate
Copy link
Contributor

Fix pr is created upstream: radxa-pkg/aic8800#33

Do you know if the fix breaks pre 6.1.115 Rockchip BSP?

Checked with 6.1.99, no issues.

@coderabbitai coderabbitai bot mentioned this pull request Apr 21, 2025
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
05 Milestone: Second quarter release Framework Framework components Needs review Seeking for review Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@igorpecovnik @HeyMeco @schwar3kat @amazingfate
0