8000 Fix permissions for label `Ready to Merge` on approved pull requests by igorpecovnik · Pull Request #8079 · armbian/build · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix permissions for label Ready to Merge on approved pull requests #8079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 12, 2025
Merged

Fix permissions for label Ready to Merge on approved pull requests #8079

merged 1 commit into from
Apr 12, 2025

Conversation

igorpecovnik
Copy link
Member
@igorpecovnik igorpecovnik commented Apr 12, 2025 •
edited
Loading

Description

For labels to set we need issue write permission for GITHUB_TOKEN.

Checklist:

  • My changes generate no new warnings

@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented Apr 12, 2025 •
edited
Loading

Walkthrough

The change updates the GitHub Actions workflow configuration for labeling approved pull requests by adding a permissions section. This section explicitly defines three permissions: contents: read for reading changed files, pull-requests: write for labeling pull requests, and issues: write for modifying labels on both issues and pull requests. No changes were made to the declarations of any exported or public entities.

Possibly related PRs

Suggested reviewers

  • rpardini
    • 8000
  • hzyitc
📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1684d06 and d3aa220.

📒 Files selected for processing (1)
  • .github/workflows/pr-label-on-approved.yml (1 hunks)
🔇 Additional comments (1)
.github/workflows/pr-label-on-approved.yml (1)

3-8: Explicit Permissions Added to the Workflow

The new permissions block explicitly grants contents: read, pull-requests: write, and issues: write, which is exactly what’s needed to allow the workflow to check changed files and set labels on pull requests. This change directly addresses the PR objective of ensuring that the GITHUB_TOKEN has the necessary permissions to modify labels.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added size/small PR with less then 50 lines 05 Milestone: Second quarter release Needs review Seeking for review GitHub Actions GitHub Actions code labels Apr 12, 2025
@igorpecovnik igorpecovnik merged commit 6a86fd7 into main Apr 12, 2025
1 check passed
@igorpecovnik igorpecovnik deleted the approved branch April 12, 2025 18:04
@coderabbitai coderabbitai bot mentioned this pull request Apr 14, 2025
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpardini rpardini Awaiting requested review from rpardini rpardini is a code owner

< 5A13 span class="d-flex min-width-0 flex-1 js-hovercard-left" data-hovercard-type="user" data-hovercard-url="/users/hzyitc/hovercard" data-assignee-name="hzyitc"> @hzyitc hzyitc Awaiting requested review from hzyitc hzyitc is a code owner

Assignees
No one assigned
Labels
05 Milestone: Second quarter release GitHub Actions GitHub Actions code Needs review Seeking for review size/small PR with less then 50 lines
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@igorpecovnik
0