Stop altering global git config file and set safe per cloned repository #7910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://github.com/armbian/os/actions/runs/13882805130/job/38843739701#step:8:998 I believe this commit results in build failures. Needs inspection. |
leggewie
added a commit
to leggewie/armbian-build
that referenced
this pull request
Mar 16, 2025
git currently fails because it is usually called from outside the git directory it is supposed to work on.
leggewie
added a commit
to leggewie/armbian-build
that referenced
this pull request
Mar 16, 2025
git currently fails because it is usually called from outside the git directory it is supposed to work on.
leggewie
added a commit
to leggewie/armbian-build
that referenced
this pull request
Mar 16, 2025
git.sh currently fails because git is usually called from outside the git directory it is supposed to work on. Before ccde662 git config was called with --global which was wrong (armbian#7907) but worked from any directory. Now git config is called correctly with --local but that only works when cd'ing into the git directory first.
I have prepared a PR |
2 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace ugly workaround with a proper solution. Now safe folder is added to each cloned repository.
Closing #7907 AR-2624
How Has This Been Tested?
Checklist: