Enable fstream independently of filesystem #376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Downstream issue: arm#375 This enables fstream for embedded systems where basic file operations are available via semihosting, but not additional filesystem operations like managing directories. Change-Id: Ifaeeb1629f29ea67e622f7f880aeb3417d8fdebc
|
This passes the build, but causes some test failures - I will add test fixes here as well. |
|
@pawosm-arm please confirm you are happy with this one too, thank you! |
pawosm-arm
requested changes
Jun 17, 2025
pawosm-arm
previously approved these changes
Jun 17, 2025
|
@pratlucas , @pawosm-arm I replaced commented out lines with a check for newlib, which now looks more consistent with other checks as well as less lines changed. Please confirm you are happy with the update, thanks! |
pawosm-arm
approved these changes
Jun 17, 2025
pratlucas
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downstream issue: #375
This enables fstream for embedded systems where basic file operations are available via semihosting, but not additional filesystem operations like managing directories.