8000 Refactor(eos_cli_config_gen)!: Make ip_name_servers[].vrf required(Hold) by laxmikantchintakindi · Pull Request #5358 · aristanetworks/avd · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Refactor(eos_cli_config_gen)!: Make ip_name_servers[].vrf required(Hold) #5358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: devel
Choose a base branch
from
+22 −21
Draft

Refactor(eos_cli_config_gen)!: Make ip_name_servers[].vrf required(Hold) #5358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes 3 commits
Select commit Hold shift + click to select a range
60a75e7
Refactor(eos_cli_config_gen): Make ip_name_servers[].vrf required
May 2, 2025
4085fb8
Merge branch 'devel' into refactor/eos_cli/ip-name-server-vrf-required
Vibhu-gslab May 26, 2025
faea6cc
Merge branch 'devel' into refactor/eos_cli/ip-name-server-vrf-required
laxmikantchintakindi Jun 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions ...llections/arista/avd/molecule/eos_cli_config_gen/documentation/devices/host1.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,25 +428,25 @@ ip domain-list domain2.local

| Name Server | VRF | Priority |
| ----------- | --- | -------- |
| 10.10.128.10 | - | - |
| 10.10.129.10 | - | 0 |
| 10.10.128.10 | default | - |
| 10.10.129.10 | default | 0 |
| 10.10.128.10 | mgmt | - |
| 10.10.128.10 | TEST | 3 |
| 2001:db8::1 | - | - |
| 2001:db8::2 | - | 0 |
| 2001:db8::1 | default | - |
| 2001:db8::2 | default | 0 |
| 2001:db8::1 | mgmt | - |
| 2001:db8 8000 ::2 | TEST | 3 |

#### IP Name Servers Device Configuration

```eos
ip name-server 10.10.128.10
ip name-server vrf default 10.10.128.10
ip name-server vrf mgmt 10.10.128.10
ip name-server vrf TEST 10.10.128.10 priority 3
ip name-server 10.10.129.10 priority 0
ip name-server 2001:db8::1
ip name-server vrf default 10.10.129.10 priority 0
ip name-server vrf default 2001:db8::1
ip name-server vrf mgmt 2001:db8::1
ip name-server 2001:db8::2 priority 0
ip name-server vrf default 2001:db8::2 priority 0
ip name-server vrf TEST 2001:db8::2 priority 3
```

Expand Down
8 changes: 4 additions & 4 deletions ansible_collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/host1.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,13 +575,13 @@ ip nat profile NAT-PROFILE-TEST-VRF vrf TEST
hostname hostname-set-via-hostname-var
ip domain lookup source-interface Loopback0
ip domain lookup vrf mgt source-interface Management0
ip name-server 10.10.128.10
ip name-server vrf default 10.10.128.10
ip name-server vrf mgmt 10.10.128.10
ip name-server vrf TEST 10.10.128.10 priority 3
ip name-server 10.10.129.10 priority 0
ip name-server 2001:db8::1
ip name-server vrf default 10.10.129.10 priority 0
ip name-server vrf default 2001:db8::1
ip name-server vrf mgmt 2001:db8::1
ip name-server 2001:db8::2 priority 0
ip name-server vrf default 2001:db8::2 priority 0
ip name-server vrf TEST 2001:db8::2 priority 3
dns domain test.local
ip domain-list domain1.local
Expand Down
4 changes: 4 additions & 0 deletions ...ions/arista/avd/molecule/eos_cli_config_gen/inventory/host_vars/host1/ip-name-servers.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,11 @@
ip_name_servers:
# no VRF
- ip_address: 10.10.128.10
vrf: default
# no VRF priority
- ip_address: 10.10.129.10
priority: 0
vrf: default
# Same DNS management VRF
- ip_address: 10.10.128.10
vrf: mgmt
Expand All @@ -15,9 +17,11 @@ ip_name_servers:
priority: 3
# no VRF
- ip_address: 2001:db8::1
vrf: default
# no VRF priority
- ip_address: 2001:db8::2
priority: 0
vrf: default
# Same DNS management VRF
- ip_address: 2001:db8::1
vrf: mgmt
Expand Down
4 changes: 2 additions & 2 deletions ..._collections/arista/avd/roles/eos_cli_config_gen/docs/tables/ip-name-servers.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 2 additions & 6 deletions python-avd/pyavd/_eos_cli_config_gen/schema/__init__.py
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions python-avd/pyavd/_eos_cli_config_gen/schema/eos_cli_config_gen.schema.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/ip_name_servers.schema.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@ keys:
type: str
required: true
description: IPv4 or IPv6 address for DNS server.
# TODO: AVD 6.0 Make vrf key required(issue 4788)
vrf:
description: VRF Name.
required: true
type: str
convert_types:
- int
Expand Down
0