Fix asyn build in CI. #530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub Actions runners lack libtirpc-dev by default, causing missing rpc.h errors during ASYN dependency preparation. Install libtirpc-dev unconditionally for all Linux jobs to satisfy ASYN's default TIRPC=YES configuration [1]. [1] epics-modules/asyn@0ed37b2
Ubuntu-20.04 image is deprecated [1], causing the check to fail. Switch to ubuntu-22.04 because it's an older distro that's still available as runner. [1] actions/runner-images#11101
asyn-config.sh was being used in ASYN_HOOK in order to set TIRPC=YES when libtirpc headers were found. We don't need to set this anymore as TIRPC=YES is now the default configure for asyn builds on linux [1]. [1] epics-modules/asyn@0ed37b2
|
I forgot to mention that the best way to ensure compatibility with older platforms is to use containers, because this way we are not limited to the availability of github images, but this leads to a more complex development on CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.