8000 Sets app status to unknown if there is an error. Closes #2577 by alexec · Pull Request #2578 · argoproj/argo-cd · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Sets app status to unknown if there is an error. Closes #2577 #2578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 29, 2019
Merged

Sets app status to unknown if there is an error. Closes #2577 #2578

merged 5 commits into from
Oct 29, 2019

Conversation

alexec
Copy link
Contributor
@alexec alexec commented Oct 28, 2019 •
edited
Loading

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Optional. My organization is added to the README.
  • I've signed the CLA and my build is green (troubleshooting builds).

Closes #2577

Screen Shot 2019-10-28 at 14 12 30

golangcibot
golangcibot reviewed Oct 28, 2019
View reviewed changes
@alexec alexec changed the title Reflects sync-options: Prune=false in the UI. Closes #2577 Sets app status to unknown if there is an error. Closes #2577 Oct 28, 2019
@codecov
Copy link
codecov bot commented Oct 28, 2019 •
edited
Loading

Codecov Report

Merging #2578 into master will increase coverage by 0.05%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2578      +/-   ##
==========================================
+ Coverage   38.18%   38.23%   +0.05%     
==========================================
  Files         114      114              
  Lines       15879    15881       +2     
==========================================
+ Hits         6063     6072       +9     
+ Misses       9016     9004      -12     
- Partials      800      805       +5
Impacted Files Coverage Δ
controller/state.go 71.91% <0%> (-0.45%) ⬇️
controller/appcontroller.go 45.7% <0%> (+1.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 134469c...5c31676. Read the comment docs.

@alexec alexec marked this pull request as ready for review October 29, 2019 17:16
@alexec
Copy link
Contributor Author
alexec commented Oct 29, 2019

@alexmt please can you review? I'd like to backport to v1.2.

@alexec alexec merged commit a9a28b7 into argoproj:master Oct 29, 2019
@alexec alexec deleted the no-prune branch October 29, 2019 18:44
alexec added a commit that referenced this pull request Oct 29, 2019
@alexec
Sets app status to unknown if there is an error. Closes #2577 (#2578)
3aaca0b
alexec added a commit that referenced this pull request Oct 29, 2019
@alexec
Sets app status to unknown if there is an error. Closes #2577 (#2578)
e0de330
@alexec
Copy link
Contributor Author
alexec commented Oct 29, 2019

Back-ported to v1.2 and v1.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@golangcibot golangcibot golangcibot left review comments

@alexmt alexmt alexmt approved these changes

Assignees

@alexmt alexmt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI incorrectly mark resources as Required Pruning
3 participants
@alexec @alexmt @golangcibot
0