feat(hydrator): commit tracing (#19441) #23361
Merged
+2,733
−1,095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
agaudreault
reviewed
Jun 11, 2025
agaudreault
reviewed
Jun 11, 2025
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #23361 +/- ##
==========================================
+ Coverage 59.95% 59.98% +0.03%
==========================================
Files 342 342
Lines 58660 58792 +132
==========================================
+ Hits 35168 35268 +100
- Misses 20639 20656 +17
- Partials 2853 2868 +15 ☔ View full report in Codecov by Sentry. |
zachaller
reviewed
Jun 12, 2025
agaudreault
reviewed
Jun 12, 2025
agaudreault
reviewed
Jun 12, 2025
agaudreault
reviewed
Jun 12, 2025
agaudreault
reviewed
Jun 12, 2025
agaudreault
reviewed
Jun 12, 2025
agaudreault
reviewed
Jun 12, 2025
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
andrii-korotkov
approved these changes
Jun 13, 2025
agaudreault
reviewed
Jun 13, 2025
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev
commented
Jun 13, 2025
Comment on lines
+107
to
+108
| assert.Equal(t, metadata.Author, topMetadata.Author) | ||
| assert.Equal(t, metadata.Message, topMetadata.Message) |
There was a problem hiding this comment.
Note to self: add assertion for top-level date field
agaudreault
approved these changes
Jun 13, 2025
dsuhinin
pushed a commit
to dsuhinin/argo-cd
that referenced
this pull request
Jun 16, 2025
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
jcogilvie
pushed a commit
to Sanyaku/argo-cd
that referenced
this pull request
Jun 16, 2025
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jonathan Ogilvie <jonathan.ogilvie@sumologic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19441