8000 fix: add cooldown to prevent resetting autoheal exp backoff preemptively (cherry-pick #23057) by gdsoumya · Pull Request #23188 · argoproj/argo-cd · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: add cooldown to prevent resetting autoheal exp backoff preemptively (cherry-pick #23057) #23188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 28, 2025
Merged

fix: add cooldown to prevent resetting autoheal exp backoff preemptively (cherry-pick #23057) #23188

merged 2 commits into from
May 28, 2025

Conversation

gdsoumya
Copy link
Member

Cherry pick 23057 to 2.14 release

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@gdsoumya
fix: add cooldown to prevent resetting autoheal exp backoff preemptiv…
07b02a3 
…ely (argoproj#23057)

Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>
@gdsoumya gdsoumya requested review from a team as code owners May 28, 2025 17:39
@codecov Codecov
Copy link
codecov bot commented May 28, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.

Project coverage is 55.37%. Comparing base (5ad281e) to head (9505277).
Report is 1 commits behind head on release-2.14.

Files with missing lines Patch % Lines
controller/appcontroller.go 80.00% 2 Missing ⚠️
Additional details and impacted files 
@@               Coverage Diff                @@
##           release-2.14   #23188      +/-   ##
================================================
+ Coverage         52.91%   55.37%   +2.46%     
================================================
  Files               339      339              
  Lines             57353    57361       +8     
================================================
+ Hits              30346    31763    +1417     
+ Misses            24341    22913    -1428     
- Partials           2666     2685      +19

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdsoumya gdsoumya enabled auto-merge (squash) May 28, 2025 19:36
@gdsoumya gdsoumya merged commit a2361bf into argoproj:release-2.14 May 28, 2025
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakepettersson blakepettersson blakepettersson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gdsoumya @blakepettersson
0